All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH 1/2] nvme-multipath: fixup typo when clearing DISK_LIVE
Date: Wed, 4 Sep 2024 06:09:32 +0200	[thread overview]
Message-ID: <20240904040932.GA13295@lst.de> (raw)
In-Reply-To: <20240903180345.35253-2-hare@kernel.org>

On Tue, Sep 03, 2024 at 08:03:44PM +0200, Hannes Reinecke wrote:
> NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_ns_head', not
> 'struct nvme_ns'.
> 
> Signed-off-by: Hannes Reinecke <hare@kernel.org>
> Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Although a sentence on how this was found and if this causes
real issues wouldn't hurt.



  reply	other threads:[~2024-09-04  4:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 18:03 [PATCHv2 0/2] nvme: NSHEAD_DISK_LIVE fixes Hannes Reinecke
2024-09-03 18:03 ` [PATCH 1/2] nvme-multipath: fixup typo when clearing DISK_LIVE Hannes Reinecke
2024-09-04  4:09   ` Christoph Hellwig [this message]
2024-09-03 18:03 ` [PATCH 2/2] nvme-multipath: fix I/O stall when remapping namespaces Hannes Reinecke
2024-09-03 19:38   ` Sagi Grimberg
2024-09-04  8:20     ` Hannes Reinecke
2024-09-04  8:59       ` Hannes Reinecke
2024-09-05  6:43         ` Nilay Shroff
2024-09-05  7:06         ` Sagi Grimberg
2024-09-05  8:39           ` Hannes Reinecke
2024-09-05  9:06             ` Sagi Grimberg
2024-09-05  9:23               ` Hannes Reinecke
2024-09-04 14:52   ` Nilay Shroff
2024-09-04 15:55     ` Hannes Reinecke
2024-09-05  6:41       ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240904040932.GA13295@lst.de \
    --to=hch@lst.de \
    --cc=hare@kernel.org \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.