All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Michal Simek <michal.simek@amd.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default
Date: Wed, 4 Sep 2024 17:26:52 +0100	[thread overview]
Message-ID: <20240904162652.GB4792@kernel.org> (raw)
In-Reply-To: <20240903184912.4151926-1-sean.anderson@linux.dev>

On Tue, Sep 03, 2024 at 02:49:12PM -0400, Sean Anderson wrote:
> This NIC doesn't have hardware IRQ coalescing. Under high load,
> interrupts can adversely affect performance. To mitigate this, enable
> software IRQ coalescing by default. On my system this increases receive
> throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases
> interrupts from 69489/sec to 2016/sec, and decreases CPU utilization
> from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I
> can tell).
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Nice performance improvement :)

Reviewed-by: Simon Horman <horms@kernel.org>


WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default
Date: Wed, 4 Sep 2024 17:26:52 +0100	[thread overview]
Message-ID: <20240904162652.GB4792@kernel.org> (raw)
In-Reply-To: <20240903184912.4151926-1-sean.anderson@linux.dev>

On Tue, Sep 03, 2024 at 02:49:12PM -0400, Sean Anderson wrote:
> This NIC doesn't have hardware IRQ coalescing. Under high load,
> interrupts can adversely affect performance. To mitigate this, enable
> software IRQ coalescing by default. On my system this increases receive
> throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases
> interrupts from 69489/sec to 2016/sec, and decreases CPU utilization
> from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I
> can tell).
> 
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Nice performance improvement :)

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2024-09-04 16:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 18:49 [PATCH net-next] net: cadence: macb: Enable software IRQ coalescing by default Sean Anderson
2024-09-04 16:26 ` Simon Horman [this message]
2024-09-04 16:26   ` Simon Horman
2024-09-05  0:20 ` patchwork-bot+netdevbpf
2024-09-05  0:20   ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240904162652.GB4792@kernel.org \
    --to=horms@kernel.org \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sean.anderson@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.