All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>, Jens Axboe <axboe@kernel.dk>,
	 Jann Horn <jannh@google.com>,
	 Linus Torvalds <torvalds@linux-foundation.org>,
	 Mike Rapoport <rppt@kernel.org>
Cc: Kees Cook <kees@kernel.org>, Christoph Lameter <cl@linux.com>,
	 Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	 Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	 Andrew Morton <akpm@linux-foundation.org>,
	 Roman Gushchin <roman.gushchin@linux.dev>,
	 Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	linux-mm@kvack.org,  linux-fsdevel@vger.kernel.org,
	Christian Brauner <brauner@kernel.org>
Subject: [PATCH v4 14/17] slab: remove kmem_cache_create_rcu()
Date: Thu, 05 Sep 2024 09:56:57 +0200	[thread overview]
Message-ID: <20240905-work-kmem_cache_args-v4-14-ed45d5380679@kernel.org> (raw)
In-Reply-To: <20240905-work-kmem_cache_args-v4-0-ed45d5380679@kernel.org>

Now that we have ported all users of kmem_cache_create_rcu() to struct
kmem_cache_args the function is unused and can be removed.

Reviewed-by: Kees Cook <kees@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Christian Brauner <brauner@kernel.org>
---
 include/linux/slab.h |  3 ---
 mm/slab_common.c     | 43 -------------------------------------------
 2 files changed, 46 deletions(-)

diff --git a/include/linux/slab.h b/include/linux/slab.h
index f74ceb788ac1..8246f9b28f43 100644
--- a/include/linux/slab.h
+++ b/include/linux/slab.h
@@ -270,9 +270,6 @@ struct kmem_cache *kmem_cache_create_usercopy(const char *name,
 			slab_flags_t flags,
 			unsigned int useroffset, unsigned int usersize,
 			void (*ctor)(void *));
-struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size,
-					 unsigned int freeptr_offset,
-					 slab_flags_t flags);
 
 /* If NULL is passed for @args, use this variant with default arguments. */
 static inline struct kmem_cache *
diff --git a/mm/slab_common.c b/mm/slab_common.c
index 418459927670..9133b9fafcb1 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -420,49 +420,6 @@ struct kmem_cache *__kmem_cache_create(const char *name, unsigned int size,
 }
 EXPORT_SYMBOL(__kmem_cache_create);
 
-/**
- * kmem_cache_create_rcu - Create a SLAB_TYPESAFE_BY_RCU cache.
- * @name: A string which is used in /proc/slabinfo to identify this cache.
- * @size: The size of objects to be created in this cache.
- * @freeptr_offset: The offset into the memory to the free pointer
- * @flags: SLAB flags
- *
- * Cannot be called within an interrupt, but can be interrupted.
- *
- * See kmem_cache_create() for an explanation of possible @flags.
- *
- * By default SLAB_TYPESAFE_BY_RCU caches place the free pointer outside
- * of the object. This might cause the object to grow in size. Callers
- * that have a reason to avoid this can specify a custom free pointer
- * offset in their struct where the free pointer will be placed.
- *
- * Note that placing the free pointer inside the object requires the
- * caller to ensure that no fields are invalidated that are required to
- * guard against object recycling (See SLAB_TYPESAFE_BY_RCU for
- * details.).
- *
- * Using zero as a value for @freeptr_offset is valid. To request no
- * offset UINT_MAX must be specified.
- *
- * Note that @ctor isn't supported with custom free pointers as a @ctor
- * requires an external free pointer.
- *
- * Return: a pointer to the cache on success, NULL on failure.
- */
-struct kmem_cache *kmem_cache_create_rcu(const char *name, unsigned int size,
-					 unsigned int freeptr_offset,
-					 slab_flags_t flags)
-{
-	struct kmem_cache_args kmem_args = {
-		.freeptr_offset		= freeptr_offset,
-		.use_freeptr_offset	= true,
-	};
-
-	return __kmem_cache_create_args(name, size, &kmem_args,
-					flags | SLAB_TYPESAFE_BY_RCU);
-}
-EXPORT_SYMBOL(kmem_cache_create_rcu);
-
 static struct kmem_cache *kmem_buckets_cache __ro_after_init;
 
 /**

-- 
2.45.2


  parent reply	other threads:[~2024-09-05  7:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05  7:56 [PATCH v4 00/17] slab: add struct kmem_cache_args Christian Brauner
2024-09-05  7:56 ` [PATCH v4 01/17] slab: s/__kmem_cache_create/do_kmem_cache_create/g Christian Brauner
2024-09-06  0:12   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 02/17] slab: add struct kmem_cache_args Christian Brauner
2024-09-06  0:15   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 03/17] slab: port kmem_cache_create() to " Christian Brauner
2024-09-06  0:43   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 04/17] slab: port kmem_cache_create_rcu() " Christian Brauner
2024-09-06  0:45   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 05/17] slab: port kmem_cache_create_usercopy() " Christian Brauner
2024-09-06  0:48   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 06/17] slab: pass struct kmem_cache_args to create_cache() Christian Brauner
2024-09-06  0:51   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 07/17] slab: pull kmem_cache_open() into do_kmem_cache_create() Christian Brauner
2024-09-06  0:53   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 08/17] slab: pass struct kmem_cache_args to do_kmem_cache_create() Christian Brauner
2024-09-06  0:54   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 09/17] slab: remove rcu_freeptr_offset from struct kmem_cache Christian Brauner
2024-09-06  0:55   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 10/17] slab: port KMEM_CACHE() to struct kmem_cache_args Christian Brauner
2024-09-06  0:58   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 11/17] slab: port KMEM_CACHE_USERCOPY() " Christian Brauner
2024-09-06  1:00   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 12/17] slab: create kmem_cache_create() compatibility layer Christian Brauner
2024-09-05  8:15   ` Mike Rapoport
2024-09-05 11:54   ` Vlastimil Babka
2024-09-06  1:05   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 13/17] file: port to struct kmem_cache_args Christian Brauner
2024-09-06  1:06   ` Roman Gushchin
2024-09-05  7:56 ` Christian Brauner [this message]
2024-09-06  1:08   ` [PATCH v4 14/17] slab: remove kmem_cache_create_rcu() Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 15/17] slab: make kmem_cache_create_usercopy() static inline Christian Brauner
2024-09-05  8:15   ` Mike Rapoport
2024-09-06  1:08   ` Roman Gushchin
2024-09-05  7:56 ` [PATCH v4 16/17] slab: make __kmem_cache_create() " Christian Brauner
2024-09-05  8:16   ` Mike Rapoport
2024-09-06  1:10   ` Roman Gushchin
2024-09-05  7:57 ` [PATCH v4 17/17] io_uring: port to struct kmem_cache_args Christian Brauner
2024-09-05 12:02 ` [PATCH v4 00/17] slab: add " Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905-work-kmem_cache_args-v4-14-ed45d5380679@kernel.org \
    --to=brauner@kernel.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jannh@google.com \
    --cc=kees@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=rppt@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.