Re: Problems running DAMON kunit tests with spinlock debugging enabled

[SeongJae Park <sj@kernel.org>]

On Wed, 4 Sep 2024 12:06:29 -0700 Guenter Roeck <linux@roeck-us.net> wrote:

> On 9/4/24 10:53, SeongJae Park wrote:
> > On Tue, 3 Sep 2024 19:46:44 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
> >> On 9/3/24 19:24, Guenter Roeck wrote:
> >>> On 9/3/24 18:00, SeongJae Park wrote:
> >>>> Hi Guenter,
> >>>>
> >>>> On Tue, 3 Sep 2024 12:23:50 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
[...]
> >>> Some more problems. I tried your patch on various architectures.
> >>> Unfortunately, that didn't turn out well. See below for some of the failures.
> > 
> > Nice finding, thank you for reporting this!  Just to be clear, seems this is
> > independent from the originally reported issue or the fix for it.  Please let
> > me know if not.
> > 
> 
> It is a different problem.

Thank you for confirming :)

[...]
> > I think doing the skip if the resulting
> > aggr_interval is zero would make more sense.  Having more comments would also
> > be nice.
> > 
> 
> Sure; the above was not intended to be a final (or even acceptable) fix,
> just a workaround to let me run tests with damon kunit tests enabled
> on 32-bit systems.

Thank you for kindly agreeing and clarifying.  I just posted the fix:
https://lore.kernel.org/20240905162423.74053-1-sj@kernel.org

Hopefully the patch explains more details and my opinions.


Thanks,
SJ

> 
> Thanks,
> Guenter