All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: SeongJae Park <sj@kernel.org>, damon@lists.linux.dev
Subject: Re: Problems running DAMON kunit tests with spinlock debugging enabled
Date: Thu,  5 Sep 2024 11:08:43 -0700	[thread overview]
Message-ID: <20240905180843.46016-1-sj@kernel.org> (raw)
In-Reply-To: <64f1b6bf-174f-4ac2-a43c-2783c1cd3999@roeck-us.net>

On Thu, 5 Sep 2024 11:04:51 -0700 Guenter Roeck <linux@roeck-us.net> wrote:

> On 9/5/24 10:35, SeongJae Park wrote:
> > Hi Guenter,
> > 
> > On Wed, 4 Sep 2024 14:04:03 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
> > 
> > [...]
> >> Here is another problem. With all other problems fixed, when running on a 32-bit system:
[...]
> > As you also mentioned, this function may better to be significantly re-written
> > with overflows in mind.  However, I have no enough time and setup to
> > sufficiently test the fix for now, due to some personal reasons.  Also, the
> > issue is important, but not time-critical for now, in my humble opinion.
> > Please let me know if someone has different opinions.
> > 
> > So, I made one possible fix off the top of my head, and posted as an RFC patch:
> > https://lore.kernel.org/20240905172405.46995-1-sj@kernel.org
> > 
> > I only tested that against the kunit test on my 64bit machine.  After I get
> > some time and setup (maybe 1-2 weeks later), I will take more time to review
> > the code, do more tests, and post RFC-dropped version.
> > 
> 
> No worries. I queued the RFC patch up in my testbed, so we should get results
> for all targets later today (or maybe tomorrow, the testbed is busy with stable
> release tests).

No problem, please take your time :)


Thanks,
SJ

> 
> Guenter

  reply	other threads:[~2024-09-05 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 19:23 Problems running DAMON kunit tests with spinlock debugging enabled Guenter Roeck
2024-09-04  1:00 ` SeongJae Park
2024-09-04  2:24   ` Guenter Roeck
2024-09-04  2:46     ` Guenter Roeck
2024-09-04 17:53       ` SeongJae Park
2024-09-04 19:06         ` Guenter Roeck
2024-09-05 16:30           ` SeongJae Park
2024-09-04 21:04         ` Guenter Roeck
2024-09-05 17:35           ` SeongJae Park
2024-09-05 18:04             ` Guenter Roeck
2024-09-05 18:08               ` SeongJae Park [this message]
2024-09-05  6:14         ` SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905180843.46016-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.