All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
Cc: Sergey Matyukevich <geomatsi@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/3] package/wpa_supplicant: add missing config for WPA3 entreprise
Date: Thu, 5 Sep 2024 21:27:57 +0200	[thread overview]
Message-ID: <20240905212757.1d6f5dc0@windsurf> (raw)
In-Reply-To: <20240905152110.1317154-1-guillaume.chaye@zeetim.com>

Hello Guillaume,

On Thu,  5 Sep 2024 17:21:10 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>

Thanks for your patch!

It is not immediately obvious that CONFIG_SUITEB and CONFIG_SUITEB192
are related to WPA3 enterprise. This kind of patch would greatly
benefit from having a non-empty commit log, with a bit of explanation
and/or reference to relevant documentation. Do you think you could do
this?

Generally speaking, an empty commit log is almost always wrong, and
should be extended to be non-empty, with relevant explanations helping
the maintainers/reviewers what the change is doing, and how.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-09-05 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 15:21 [Buildroot] [PATCH 3/3] package/wpa_supplicant: add missing config for WPA3 entreprise Guillaume GC. Chaye
2024-09-05 19:27 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240905212757.1d6f5dc0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=geomatsi@gmail.com \
    --cc=guillaume.chaye@zeetim.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.