[Buildroot] [PATCH 3/3] package/wpa_supplicant: add missing config for WPA3 entreprise

[Buildroot] [PATCH 3/3] package/wpa_supplicant: add missing config for WPA3 entreprise

[Guillaume GC. Chaye]

Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
---
 package/wpa_supplicant/wpa_supplicant.mk | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index 984959f679..f37a7db821 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -131,13 +131,17 @@ WPA_SUPPLICANT_CONFIG_ENABLE += \
 	CONFIG_DPP \
 	CONFIG_SAE \
 	CONFIG_SAE_PK \
-	CONFIG_OWE
+	CONFIG_OWE \
+	CONFIG_SUITEB \
+	CONFIG_SUITEB192
 else
 WPA_SUPPLICANT_CONFIG_DISABLE += \
 	CONFIG_DPP \
 	CONFIG_SAE \
 	CONFIG_SAE_PK \
-	CONFIG_OWE
+	CONFIG_OWE \
+	CONFIG_SUITEB \
+	CONFIG_SUITEB192
 endif
 
 # Try to use openssl if it's already available
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] package/wpa_supplicant: add missing config for WPA3 entreprise

[Thomas Petazzoni via buildroot]

Hello Guillaume,

On Thu,  5 Sep 2024 17:21:10 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>

Thanks for your patch!

It is not immediately obvious that CONFIG_SUITEB and CONFIG_SUITEB192
are related to WPA3 enterprise. This kind of patch would greatly
benefit from having a non-empty commit log, with a bit of explanation
and/or reference to relevant documentation. Do you think you could do
this?

Generally speaking, an empty commit log is almost always wrong, and
should be extended to be non-empty, with relevant explanations helping
the maintainers/reviewers what the change is doing, and how.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot