From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, thepacketgeek@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davej@codemonkey.org.uk, vlad.wing@gmail.com, max@kutsevol.com
Subject: Re: [PATCH net-next v2 02/10] net: netconsole: split send_ext_msg_udp() function
Date: Mon, 9 Sep 2024 16:58:48 +0100 [thread overview]
Message-ID: <20240909155848.GB2097826@kernel.org> (raw)
In-Reply-To: <20240909130756.2722126-3-leitao@debian.org>
On Mon, Sep 09, 2024 at 06:07:43AM -0700, Breno Leitao wrote:
> The send_ext_msg_udp() function has become quite large, currently
> spanning 102 lines. Its complexity, along with extensive pointer and
> offset manipulation, makes it difficult to read and error-prone.
>
> The function has evolved over time, and it’s now due for a refactor.
>
> To improve readability and maintainability, isolate the case where no
> message fragmentation occurs into a separate function, into a new
> send_msg_no_fragmentation() function. This scenario covers about 95% of
> the messages.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-09 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 13:07 [PATCH net-next v2 00/10] netconsole refactoring and warning fix Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 01/10] net: netconsole: remove msg_ready variable Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 02/10] net: netconsole: split send_ext_msg_udp() function Breno Leitao
2024-09-09 15:58 ` Simon Horman [this message]
2024-09-09 13:07 ` [PATCH net-next v2 03/10] net: netconsole: separate fragmented message handling in send_ext_msg Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 04/10] net: netconsole: rename body to msg_body Breno Leitao
2024-09-09 16:03 ` Simon Horman
2024-09-09 13:07 ` [PATCH net-next v2 05/10] net: netconsole: introduce variable to track body length Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 06/10] net: netconsole: track explicitly if msgbody was written to buffer Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 07/10] net: netconsole: extract release appending into separate function Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 08/10] net: netconsole: do not pass userdata up to the tail Breno Leitao
2024-09-09 16:05 ` Simon Horman
2024-09-10 9:44 ` Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 09/10] net: netconsole: split send_msg_fragmented Breno Leitao
2024-09-09 13:07 ` [PATCH net-next v2 10/10] net: netconsole: fix wrong warning Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909155848.GB2097826@kernel.org \
--to=horms@kernel.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
--cc=vlad.wing@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.