All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yiyang Wu <toolmanp@tlmp.cc>
Cc: Chao Yu <yuchao0@huawei.com>,
	linux-erofs@lists.ozlabs.org, oe-kbuild-all@lists.linux.dev
Subject: [xiang-erofs:dev-test 9/12] fs/erofs/inode.c:19:56: error: 'off' undeclared
Date: Mon, 9 Sep 2024 16:07:41 +0800	[thread overview]
Message-ID: <202409091602.2XlSy6FO-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head:   c45b42bcbc9c3fb421b8a4f7b3112b401971530b
commit: afcb9dd4a55ab82970251b75c2a5461025ed4d8a [9/12] erofs: refactor read_inode calling convention
config: i386-buildonly-randconfig-003-20240909 (https://download.01.org/0day-ci/archive/20240909/202409091602.2XlSy6FO-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240909/202409091602.2XlSy6FO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409091602.2XlSy6FO-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/string.h:12,
                    from arch/x86/include/asm/page_32.h:18,
                    from arch/x86/include/asm/page.h:14,
                    from arch/x86/include/asm/thread_info.h:12,
                    from include/linux/thread_info.h:60,
                    from include/linux/spinlock.h:60,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from fs/erofs/internal.h:10,
                    from fs/erofs/xattr.h:9,
                    from fs/erofs/inode.c:7:
   fs/erofs/inode.c: In function 'erofs_fill_symlink':
>> fs/erofs/inode.c:19:56: error: 'off' undeclared (first use in this function)
      19 |             check_add_overflow(m_pofs, inode->i_size, &off) ||
         |                                                        ^~~
   include/linux/overflow.h:68:60: note: in definition of macro 'check_add_overflow'
      68 |         __must_check_overflow(__builtin_add_overflow(a, b, d))
         |                                                            ^
   fs/erofs/inode.c:19:56: note: each undeclared identifier is reported only once for each function it appears in
      19 |             check_add_overflow(m_pofs, inode->i_size, &off) ||
         |                                                        ^~~
   include/linux/overflow.h:68:60: note: in definition of macro 'check_add_overflow'
      68 |         __must_check_overflow(__builtin_add_overflow(a, b, d))
         |                                                            ^


vim +/off +19 fs/erofs/inode.c

    10	
    11	static int erofs_fill_symlink(struct inode *inode, void *kaddr,
    12				      unsigned int m_pofs)
    13	{
    14		struct erofs_inode *vi = EROFS_I(inode);
    15	
    16		m_pofs += vi->xattr_isize;
    17		/* check if it cannot be handled with fast symlink scheme */
    18		if (vi->datalayout != EROFS_INODE_FLAT_INLINE || inode->i_size < 0 ||
  > 19		    check_add_overflow(m_pofs, inode->i_size, &off) ||
    20		    off > i_blocksize(inode))
    21			return 0;
    22	
    23		inode->i_link = kmemdup_nul(kaddr + m_pofs, inode->i_size, GFP_KERNEL);
    24		return inode->i_link ? 0 : -ENOMEM;
    25	}
    26	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Yiyang Wu <toolmanp@tlmp.cc>
Cc: oe-kbuild-all@lists.linux.dev, Xiang Gao <xiang@kernel.org>,
	linux-erofs@lists.ozlabs.org, Chao Yu <yuchao0@huawei.com>,
	Chao Yu <chao@kernel.org>
Subject: [xiang-erofs:dev-test 9/12] fs/erofs/inode.c:19:56: error: 'off' undeclared
Date: Mon, 9 Sep 2024 16:07:41 +0800	[thread overview]
Message-ID: <202409091602.2XlSy6FO-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head:   c45b42bcbc9c3fb421b8a4f7b3112b401971530b
commit: afcb9dd4a55ab82970251b75c2a5461025ed4d8a [9/12] erofs: refactor read_inode calling convention
config: i386-buildonly-randconfig-003-20240909 (https://download.01.org/0day-ci/archive/20240909/202409091602.2XlSy6FO-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240909/202409091602.2XlSy6FO-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409091602.2XlSy6FO-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/string.h:12,
                    from arch/x86/include/asm/page_32.h:18,
                    from arch/x86/include/asm/page.h:14,
                    from arch/x86/include/asm/thread_info.h:12,
                    from include/linux/thread_info.h:60,
                    from include/linux/spinlock.h:60,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from fs/erofs/internal.h:10,
                    from fs/erofs/xattr.h:9,
                    from fs/erofs/inode.c:7:
   fs/erofs/inode.c: In function 'erofs_fill_symlink':
>> fs/erofs/inode.c:19:56: error: 'off' undeclared (first use in this function)
      19 |             check_add_overflow(m_pofs, inode->i_size, &off) ||
         |                                                        ^~~
   include/linux/overflow.h:68:60: note: in definition of macro 'check_add_overflow'
      68 |         __must_check_overflow(__builtin_add_overflow(a, b, d))
         |                                                            ^
   fs/erofs/inode.c:19:56: note: each undeclared identifier is reported only once for each function it appears in
      19 |             check_add_overflow(m_pofs, inode->i_size, &off) ||
         |                                                        ^~~
   include/linux/overflow.h:68:60: note: in definition of macro 'check_add_overflow'
      68 |         __must_check_overflow(__builtin_add_overflow(a, b, d))
         |                                                            ^


vim +/off +19 fs/erofs/inode.c

    10	
    11	static int erofs_fill_symlink(struct inode *inode, void *kaddr,
    12				      unsigned int m_pofs)
    13	{
    14		struct erofs_inode *vi = EROFS_I(inode);
    15	
    16		m_pofs += vi->xattr_isize;
    17		/* check if it cannot be handled with fast symlink scheme */
    18		if (vi->datalayout != EROFS_INODE_FLAT_INLINE || inode->i_size < 0 ||
  > 19		    check_add_overflow(m_pofs, inode->i_size, &off) ||
    20		    off > i_blocksize(inode))
    21			return 0;
    22	
    23		inode->i_link = kmemdup_nul(kaddr + m_pofs, inode->i_size, GFP_KERNEL);
    24		return inode->i_link ? 0 : -ENOMEM;
    25	}
    26	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2024-09-09  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09  8:07 kernel test robot [this message]
2024-09-09  8:07 ` [xiang-erofs:dev-test 9/12] fs/erofs/inode.c:19:56: error: 'off' undeclared kernel test robot
2024-09-09  8:10 ` Gao Xiang
2024-09-09  8:10   ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409091602.2XlSy6FO-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=toolmanp@tlmp.cc \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.