* [failures] mm-drop-unused-set_pte_safe.patch removed from -mm tree
@ 2024-09-10 20:14 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-09-10 20:14 UTC (permalink / raw)
To: mm-commits, ryan.roberts, rppt, david, anshuman.khandual, akpm
The quilt patch titled
Subject: mm: drop unused set_pte_safe()
has been removed from the -mm tree. Its filename was
mm-drop-unused-set_pte_safe.patch
This patch was dropped because it had testing failures
------------------------------------------------------
From: Anshuman Khandual <anshuman.khandual@arm.com>
Subject: mm: drop unused set_pte_safe()
Date: Tue, 10 Sep 2024 15:40:26 +0530
All set_pte_safe() usage have been dropped after the commit eccd906484d1
("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page")
This just drops now unused helper set_pte_safe().
Besides this macro was buggy due to doing direct dereferencing of the pte,
and if it were to be kept, it should have been updated to use a single
call to ptep_get().
Link: https://lkml.kernel.org/r/20240910101026.428808-1-anshuman.khandual@arm.com
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: "Mike Rapoport (IBM)" <rppt@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
include/linux/pgtable.h | 6 ------
1 file changed, 6 deletions(-)
--- a/include/linux/pgtable.h~mm-drop-unused-set_pte_safe
+++ a/include/linux/pgtable.h
@@ -1064,12 +1064,6 @@ static inline int pgd_same(pgd_t pgd_a,
* same value. Otherwise, use the typical "set" helpers and flush the
* TLB.
*/
-#define set_pte_safe(ptep, pte) \
-({ \
- WARN_ON_ONCE(pte_present(*ptep) && !pte_same(*ptep, pte)); \
- set_pte(ptep, pte); \
-})
-
#define set_pmd_safe(pmdp, pmd) \
({ \
WARN_ON_ONCE(pmd_present(*pmdp) && !pmd_same(*pmdp, pmd)); \
_
Patches currently in -mm which might be from anshuman.khandual@arm.com are
mm-debug_vm_pgtable-use-pxdp_get-for-accessing-page-table-entries.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-09-10 20:14 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-10 20:14 [failures] mm-drop-unused-set_pte_safe.patch removed from -mm tree Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.