Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU

From: Lee Jones <lee@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Junhao Xie" <bigfoot@classfun.cn>,
	devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-leds@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Chukun Pan" <amadeus@jmu.edu.cn>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Günter Röck" <linux@roeck-us.net>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh@kernel.org>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>
Subject: Re: [PATCH 1/9] mfd: Add driver for Photonicat power management MCU
Date: Thu, 12 Sep 2024 08:55:23 +0100	[thread overview]
Message-ID: <20240912075523.GB24460@google.com> (raw)
In-Reply-To: <917ac8d8-a483-422c-a408-cdd44793e910@kernel.org>

On Sun, 08 Sep 2024, Krzysztof Kozlowski wrote:

> On 07/09/2024 16:33, Junhao Xie wrote:
> > On 2024/9/7 16:44, Markus Elfring wrote:
> >> …
> >>> +++ b/include/linux/mfd/photonicat-pmu.h
> >>> @@ -0,0 +1,86 @@
> >> …
> >>> +#ifndef _PHOTONICAT_PMU_H
> >>> +#define _PHOTONICAT_PMU_H
> >> …
> >>
> >> I suggest to omit leading underscores from such identifiers.
> >> https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
> >>
> >> Regards,
> >> Markus
> > 
> > Thanks for your suggestion, does this look better?
> > #ifndef MFD_PHOTONICAT_PMU_H
> > #define MFD_PHOTONICAT_PMU_H

Yes, this is better.

> <form letter>
> Feel free to ignore all comments from Markus, regardless whether the
> suggestion is reasonable or not. This person is banned from LKML and
> several maintainers ignore Markus' feedback, because it is just a waste
> of time.
> </form letter>

If you really _must_ do this, at least keep it factual.

To the best of my knowledge Markus is not banned from LKML.

-- 
Lee Jones [李琼斯]