All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Guillaume GC. Chaye" <guillaume.chaye@zeetim.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCHv2 2/2] package/librsvg: Add support of SVG in gdk-pixbuf
Date: Sat, 14 Sep 2024 11:03:58 +0200	[thread overview]
Message-ID: <20240914110358.12264404@windsurf> (raw)
In-Reply-To: <20240911130407.2925548-2-guillaume.chaye@zeetim.com>

Hello,

On Wed, 11 Sep 2024 15:04:07 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>

Thanks for the v2, but for a change like this, a commit message cannot
be empty. What is the problem? Why and how is your change fixing it?

Also, your commit title says "add support of SVG in gdk-pixbuf", but
the patch seems to do the opposite: add gdk-pixbuf support in librsvg.
Could you please clarify?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-09-14  9:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 13:04 [Buildroot] [PATCHv2 1/2] package/gdk-pixbuf: fix update cache hook Guillaume GC. Chaye
2024-09-11 13:04 ` [Buildroot] [PATCHv2 2/2] package/librsvg: Add support of SVG in gdk-pixbuf Guillaume GC. Chaye
2024-09-14  9:03   ` Thomas Petazzoni via buildroot [this message]
2024-09-14  9:02 ` [Buildroot] [PATCHv2 1/2] package/gdk-pixbuf: fix update cache hook Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240914110358.12264404@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=guillaume.chaye@zeetim.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.