[Buildroot] [PATCHv2 1/2] package/gdk-pixbuf: fix update cache hook

[Buildroot] [PATCHv2 1/2] package/gdk-pixbuf: fix update cache hook

[Guillaume GC. Chaye]

Move hook at the rootfs generation so all dependencies are
correctly added in loaders.cache.

Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
---
 package/gdk-pixbuf/gdk-pixbuf.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gdk-pixbuf/gdk-pixbuf.mk b/package/gdk-pixbuf/gdk-pixbuf.mk
index e041d2cbde..a8a21f0532 100644
--- a/package/gdk-pixbuf/gdk-pixbuf.mk
+++ b/package/gdk-pixbuf/gdk-pixbuf.mk
@@ -82,7 +82,7 @@ define GDK_PIXBUF_UPDATE_CACHE
 	$(SED) 's,^"lib,"/usr/lib,g' \
 		$(TARGET_DIR)/usr/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache
 endef
-GDK_PIXBUF_POST_INSTALL_TARGET_HOOKS += GDK_PIXBUF_UPDATE_CACHE
+GDK_PIXBUF_ROOTFS_PRE_CMD_HOOKS += GDK_PIXBUF_UPDATE_CACHE
 endif
 
 # Target gdk-pixbuf needs loaders.cache populated to build for the
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCHv2 2/2] package/librsvg: Add support of SVG in gdk-pixbuf

[Guillaume GC. Chaye]

Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>
---
 package/librsvg/librsvg.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/librsvg/librsvg.mk b/package/librsvg/librsvg.mk
index 81a6667817..6b9200084b 100644
--- a/package/librsvg/librsvg.mk
+++ b/package/librsvg/librsvg.mk
@@ -12,7 +12,7 @@ LIBRSVG_INSTALL_STAGING = YES
 LIBRSVG_CONF_ENV = \
 	LIBS=$(TARGET_NLS_LIBS) \
 	RUST_TARGET=$(RUSTC_TARGET_NAME)
-LIBRSVG_CONF_OPTS = --disable-pixbuf-loader --disable-tools
+LIBRSVG_CONF_OPTS = --enable-pixbuf-loader --disable-tools
 HOST_LIBRSVG_CONF_OPTS = --enable-introspection=no
 LIBRSVG_DEPENDENCIES = cairo host-gdk-pixbuf gdk-pixbuf host-rustc libglib2 libxml2 pango \
 	$(TARGET_NLS_DEPENDENCIES)
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCHv2 2/2] package/librsvg: Add support of SVG in gdk-pixbuf

[Thomas Petazzoni via buildroot]

Hello,

On Wed, 11 Sep 2024 15:04:07 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Signed-off-by: Guillaume GC. Chaye <guillaume.chaye@zeetim.com>

Thanks for the v2, but for a change like this, a commit message cannot
be empty. What is the problem? Why and how is your change fixing it?

Also, your commit title says "add support of SVG in gdk-pixbuf", but
the patch seems to do the opposite: add gdk-pixbuf support in librsvg.
Could you please clarify?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCHv2 1/2] package/gdk-pixbuf: fix update cache hook

[Thomas Petazzoni via buildroot]

Hello Guillaume,

On Wed, 11 Sep 2024 15:04:06 +0200
"Guillaume GC. Chaye" <guillaume.chaye@zeetim.com> wrote:

> Move hook at the rootfs generation so all dependencies are
> correctly added in loaders.cache.

Thanks for the new iteration, but this commit log is unfortunately
still insufficient. What is the problem? What are those "all
dependencies"? How is this fixing your problem? All of that needs to be
explained in your commit message so that when we go back to this in 5
years we remember the reason why we did this change.

Could you submit a v3 with a much more detailed commit log?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot