All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: Possible misleading information in rockchip,rk3588-cru.yaml
Date: Mon, 16 Sep 2024 17:33:49 +0100	[thread overview]
Message-ID: <20240916-neuron-surfer-32db6440e1ad@spud> (raw)
In-Reply-To: <ZuIJgiN2xp6oPrHD@pineapple>

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

On Wed, Sep 11, 2024 at 09:20:02PM +0000, Yao Zi wrote:
> Hi,
> 
> rockchip,rk3588-cru.yaml, dt-binding for RK3588 clock and reset module,
> contains description of customized property "rockchip,grf",
> 
>   rockchip,grf:
>     $ref: /schemas/types.yaml#/definitions/phandle
>     description: >
>       phandle to the syscon managing the "general register files". It is
>       used for GRF muxes, if missing any muxes present in the GRF will
>       not be available.
> 
> But after doing some searching, I found that clk-rk3588.c actually
> defines no clock hardware with MUXGRF type. This is also true in in the
> vendor code[1], it seems there is actually no GRF mux on RK3588
> platform.

Have you been able to check the datasheet/register map for this piece of
hardware? Does it have a grf register region?
Wouldn't be surprised if it didn't, and the cause of it being in the
binding was nothing more than copy-paste.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Yao Zi <ziyao@disroot.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: Possible misleading information in rockchip,rk3588-cru.yaml
Date: Mon, 16 Sep 2024 17:33:49 +0100	[thread overview]
Message-ID: <20240916-neuron-surfer-32db6440e1ad@spud> (raw)
In-Reply-To: <ZuIJgiN2xp6oPrHD@pineapple>


[-- Attachment #1.1: Type: text/plain, Size: 947 bytes --]

On Wed, Sep 11, 2024 at 09:20:02PM +0000, Yao Zi wrote:
> Hi,
> 
> rockchip,rk3588-cru.yaml, dt-binding for RK3588 clock and reset module,
> contains description of customized property "rockchip,grf",
> 
>   rockchip,grf:
>     $ref: /schemas/types.yaml#/definitions/phandle
>     description: >
>       phandle to the syscon managing the "general register files". It is
>       used for GRF muxes, if missing any muxes present in the GRF will
>       not be available.
> 
> But after doing some searching, I found that clk-rk3588.c actually
> defines no clock hardware with MUXGRF type. This is also true in in the
> vendor code[1], it seems there is actually no GRF mux on RK3588
> platform.

Have you been able to check the datasheet/register map for this piece of
hardware? Does it have a grf register region?
Wouldn't be surprised if it didn't, and the cause of it being in the
binding was nothing more than copy-paste.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2024-09-16 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11 21:20 Possible misleading information in rockchip,rk3588-cru.yaml Yao Zi
2024-09-11 21:20 ` Yao Zi
2024-09-16 16:33 ` Conor Dooley [this message]
2024-09-16 16:33   ` Conor Dooley
2024-09-16 17:38   ` Yao Zi
2024-09-16 17:38     ` Yao Zi
2024-09-17 21:13     ` Conor Dooley
2024-09-17 21:13       ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240916-neuron-surfer-32db6440e1ad@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.