From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Chanh Nguyen <chanh@os.amperecomputing.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Thang Nguyen <thang@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Khanh Pham <khpham@amperecomputing.com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add adt7462
Date: Wed, 18 Sep 2024 17:09:06 -0500 [thread overview]
Message-ID: <20240918220906.GB2216504-robh@kernel.org> (raw)
In-Reply-To: <bc13d8fd-4f03-4445-bc4a-1e0ca7c23ef7@kernel.org>
On Wed, Sep 18, 2024 at 03:09:23PM +0200, Krzysztof Kozlowski wrote:
> On 18/09/2024 12:32, Chanh Nguyen wrote:
> > Add device tree binding and example for adt7462 device.
> >
> > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> > ---
> > .../bindings/hwmon/onnn,adt7462.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> Where is any user? This is supposed to be sent along driver change
> implementing this compatible.
Since I2C subsystem will strip the vendor prefix and match "adt7462" to
the existing i2c_device_id, no driver change is needed for it to work.
Though for good hygene, an of_device_id entry should be added.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Thang Nguyen <thang@os.amperecomputing.com>,
linux-kernel@vger.kernel.org,
Phong Vo <phong@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Khanh Pham <khpham@amperecomputing.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Open Source Submission <patches@amperecomputing.com>,
Guenter Roeck <linux@roeck-us.net>,
Chanh Nguyen <chanh@os.amperecomputing.com>
Subject: Re: [PATCH] dt-bindings: hwmon: Add adt7462
Date: Wed, 18 Sep 2024 17:09:06 -0500 [thread overview]
Message-ID: <20240918220906.GB2216504-robh@kernel.org> (raw)
In-Reply-To: <bc13d8fd-4f03-4445-bc4a-1e0ca7c23ef7@kernel.org>
On Wed, Sep 18, 2024 at 03:09:23PM +0200, Krzysztof Kozlowski wrote:
> On 18/09/2024 12:32, Chanh Nguyen wrote:
> > Add device tree binding and example for adt7462 device.
> >
> > Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> > ---
> > .../bindings/hwmon/onnn,adt7462.yaml | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> Where is any user? This is supposed to be sent along driver change
> implementing this compatible.
Since I2C subsystem will strip the vendor prefix and match "adt7462" to
the existing i2c_device_id, no driver change is needed for it to work.
Though for good hygene, an of_device_id entry should be added.
Rob
next prev parent reply other threads:[~2024-09-18 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 10:32 [PATCH] dt-bindings: hwmon: Add adt7462 Chanh Nguyen
2024-09-18 10:32 ` Chanh Nguyen
2024-09-18 13:09 ` Krzysztof Kozlowski
2024-09-18 13:09 ` Krzysztof Kozlowski
2024-09-18 16:07 ` Chanh Nguyen
2024-09-18 17:10 ` Guenter Roeck
2024-09-18 22:09 ` Rob Herring [this message]
2024-09-18 22:09 ` Rob Herring
2024-09-18 22:05 ` Rob Herring
2024-09-18 22:05 ` Rob Herring
2024-09-19 9:43 ` Chanh Nguyen
2024-09-19 9:43 ` Chanh Nguyen
2024-09-19 10:39 ` Krzysztof Kozlowski
2024-09-19 10:39 ` Krzysztof Kozlowski
2024-09-19 15:02 ` Chanh Nguyen
2024-09-19 15:02 ` Chanh Nguyen
2024-09-19 15:14 ` Guenter Roeck
2024-09-19 15:14 ` Guenter Roeck
2024-09-19 15:54 ` Chanh Nguyen
2024-09-19 15:54 ` Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240918220906.GB2216504-robh@kernel.org \
--to=robh@kernel.org \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=khpham@amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.