All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>
Subject: [PATCH v6 15/19] test: Avoid double echo when starting up
Date: Fri, 20 Sep 2024 08:01:50 +0200	[thread overview]
Message-ID: <20240920060158.106612-16-sjg@chromium.org> (raw)
In-Reply-To: <20240920060158.106612-1-sjg@chromium.org>

There is a very annoying bug at present where the terminal echos part
of the first command sent to the board. This happens because the
terminal is still set to echo for a period until Labgrid starts up and
can change this.

Fix this by disabling echo (and other terminal features) as soon as the
spawn happens.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

Changes in v6:
- Rebase without an earlier patch

Changes in v2:
- Only disable echo if a terminal is detected

 test/py/u_boot_spawn.py | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/test/py/u_boot_spawn.py b/test/py/u_boot_spawn.py
index 24d369035e5..f2398098a00 100644
--- a/test/py/u_boot_spawn.py
+++ b/test/py/u_boot_spawn.py
@@ -11,6 +11,8 @@ import pty
 import pytest
 import signal
 import select
+import sys
+import termios
 import time
 import traceback
 
@@ -115,11 +117,23 @@ class Spawn:
             finally:
                 os._exit(255)
 
+        old = None
         try:
+            if os.isatty(sys.stdout.fileno()):
+                new = termios.tcgetattr(self.fd)
+                old = new
+                new[3] = new[3] & ~(termios.ICANON | termios.ISIG)
+                new[3] = new[3] & ~termios.ECHO
+                new[6][termios.VMIN] = 0
+                new[6][termios.VTIME] = 0
+                termios.tcsetattr(self.fd, termios.TCSANOW, new)
+
             self.poll = select.poll()
             self.poll.register(self.fd, select.POLLIN | select.POLLPRI | select.POLLERR |
                                select.POLLHUP | select.POLLNVAL)
         except:
+            if old:
+                termios.tcsetattr(self.fd, termios.TCSANOW, old)
             self.close()
             raise
 
-- 
2.43.0


  parent reply	other threads:[~2024-09-20  6:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20  6:01 [PATCH v6 00/19] labgrid: Provide an integration with Labgrid Simon Glass
2024-09-20  6:01 ` [PATCH v6 01/19] test: Allow signaling that U-Boot is ready Simon Glass
2024-09-23 20:35   ` Tom Rini
2024-09-25 12:49     ` Simon Glass
2024-09-25 17:26       ` Tom Rini
2024-09-26 21:36         ` Simon Glass
2024-09-27  2:51           ` Tom Rini
2024-10-31 18:03             ` Simon Glass
2024-10-31 18:28               ` Tom Rini
2024-11-01 15:33                 ` Simon Glass
2024-11-01 19:02                   ` Tom Rini
2024-11-02 16:32                     ` Simon Glass
2024-11-02 21:39                       ` Tom Rini
2024-09-20  6:01 ` [PATCH v6 02/19] test: Use a constant for the test timeout Simon Glass
2024-09-23 20:35   ` Tom Rini
2024-09-20  6:01 ` [PATCH v6 03/19] test: Release board after tests complete Simon Glass
2024-09-20  6:01 ` [PATCH v6 04/19] test: Allow connecting to a running board Simon Glass
2024-09-23 20:35   ` Tom Rini
2024-09-25 12:50     ` Simon Glass
2024-09-20  6:01 ` [PATCH v6 05/19] test: Avoid failing skipped tests Simon Glass
2024-09-20  6:01 ` [PATCH v6 06/19] test: Create a common function to get the config Simon Glass
2024-09-20  6:01 ` [PATCH v6 07/19] test: Introduce the concept of a role Simon Glass
2024-09-20  6:01 ` [PATCH v6 08/19] test: Move the receive code into a function Simon Glass
2024-09-20  6:01 ` [PATCH v6 09/19] test: Separate out the exception handling Simon Glass
2024-09-20  6:01 ` [PATCH v6 10/19] test: Detect dead connections Simon Glass
2024-09-20  6:01 ` [PATCH v6 11/19] test: Tidy up remaining exceptions Simon Glass
2024-09-20  6:01 ` [PATCH v6 12/19] test: Introduce lab mode Simon Glass
2024-09-20  6:01 ` [PATCH v6 13/19] test: Improve handling of sending commands Simon Glass
2024-09-20  6:01 ` [PATCH v6 14/19] test: Fix mulptiplex_log typo Simon Glass
2024-09-20  6:01 ` Simon Glass [this message]
2024-09-20  6:01 ` [PATCH v6 16/19] test: Try to shut down the lab console gracefully Simon Glass
2024-09-20  6:01 ` [PATCH v6 17/19] test: Add a section for closing the connection Simon Glass
2024-09-20  6:01 ` [PATCH v6 18/19] test: Support testing with two board-builds Simon Glass
2024-09-20  6:01 ` [PATCH v6 19/19] CI: Allow running tests on sjg lab Simon Glass
2024-09-23 20:36 ` [PATCH v6 00/19] labgrid: Provide an integration with Labgrid Tom Rini
2024-09-25 12:50   ` Simon Glass
2024-09-25 17:26     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240920060158.106612-16-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.