From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH v6 01/19] test: Allow signaling that U-Boot is ready
Date: Sat, 2 Nov 2024 15:39:15 -0600 [thread overview]
Message-ID: <20241102213915.GU3600562@bill-the-cat> (raw)
In-Reply-To: <CAFLszTgkVRkkyPDm_Kvb8-3dP6s7R9edZzmx3k43gBaiwc2N3g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Sat, Nov 02, 2024 at 10:32:18AM -0600, Simon Glass wrote:
[snip]
> My workflow for larger things is that I create a load of local
> comments. Some of these are real, some are just wip. Then I start
> turning into patches once I have something finished and working. Yes I
> should add more details of why something didn't work.
>
> Please let me know what can be done to get this integration in.
I think adopting a suffix to your scripts, along with seeing what ever
else of the feedback that was in that long thread on v3 you can
implement will help. Maybe also audit your commit messages and see if
any other details about needing X in order to work around problem Y
spring to mind, or concrete examples. Which is not because people don't
believe you found a problem, it's because we're all a bunch of engineers
and so enjoy solving a problem too and maybe have an alternative idea.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2024-11-02 21:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 6:01 [PATCH v6 00/19] labgrid: Provide an integration with Labgrid Simon Glass
2024-09-20 6:01 ` [PATCH v6 01/19] test: Allow signaling that U-Boot is ready Simon Glass
2024-09-23 20:35 ` Tom Rini
2024-09-25 12:49 ` Simon Glass
2024-09-25 17:26 ` Tom Rini
2024-09-26 21:36 ` Simon Glass
2024-09-27 2:51 ` Tom Rini
2024-10-31 18:03 ` Simon Glass
2024-10-31 18:28 ` Tom Rini
2024-11-01 15:33 ` Simon Glass
2024-11-01 19:02 ` Tom Rini
2024-11-02 16:32 ` Simon Glass
2024-11-02 21:39 ` Tom Rini [this message]
2024-09-20 6:01 ` [PATCH v6 02/19] test: Use a constant for the test timeout Simon Glass
2024-09-23 20:35 ` Tom Rini
2024-09-20 6:01 ` [PATCH v6 03/19] test: Release board after tests complete Simon Glass
2024-09-20 6:01 ` [PATCH v6 04/19] test: Allow connecting to a running board Simon Glass
2024-09-23 20:35 ` Tom Rini
2024-09-25 12:50 ` Simon Glass
2024-09-20 6:01 ` [PATCH v6 05/19] test: Avoid failing skipped tests Simon Glass
2024-09-20 6:01 ` [PATCH v6 06/19] test: Create a common function to get the config Simon Glass
2024-09-20 6:01 ` [PATCH v6 07/19] test: Introduce the concept of a role Simon Glass
2024-09-20 6:01 ` [PATCH v6 08/19] test: Move the receive code into a function Simon Glass
2024-09-20 6:01 ` [PATCH v6 09/19] test: Separate out the exception handling Simon Glass
2024-09-20 6:01 ` [PATCH v6 10/19] test: Detect dead connections Simon Glass
2024-09-20 6:01 ` [PATCH v6 11/19] test: Tidy up remaining exceptions Simon Glass
2024-09-20 6:01 ` [PATCH v6 12/19] test: Introduce lab mode Simon Glass
2024-09-20 6:01 ` [PATCH v6 13/19] test: Improve handling of sending commands Simon Glass
2024-09-20 6:01 ` [PATCH v6 14/19] test: Fix mulptiplex_log typo Simon Glass
2024-09-20 6:01 ` [PATCH v6 15/19] test: Avoid double echo when starting up Simon Glass
2024-09-20 6:01 ` [PATCH v6 16/19] test: Try to shut down the lab console gracefully Simon Glass
2024-09-20 6:01 ` [PATCH v6 17/19] test: Add a section for closing the connection Simon Glass
2024-09-20 6:01 ` [PATCH v6 18/19] test: Support testing with two board-builds Simon Glass
2024-09-20 6:01 ` [PATCH v6 19/19] CI: Allow running tests on sjg lab Simon Glass
2024-09-23 20:36 ` [PATCH v6 00/19] labgrid: Provide an integration with Labgrid Tom Rini
2024-09-25 12:50 ` Simon Glass
2024-09-25 17:26 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241102213915.GU3600562@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.