* [PATCH v1] wifi: rt2x00: convert comma to semicolon
@ 2024-09-20 2:59 Yan Zhen
2024-09-20 9:54 ` Stanislaw Gruszka
2024-10-17 16:46 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Yan Zhen @ 2024-09-20 2:59 UTC (permalink / raw)
To: stf_xl, kvalo; +Cc: linux-wireless, linux-kernel, opensource.kernel, Yan Zhen
To ensure code clarity and prevent potential errors, it's advisable
to employ the ';' as a statement separator, except when ',' are
intentionally used for specific purposes.
Signed-off-by: Yan Zhen <yanzhen@vivo.com>
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 3bb81bcff0ac..60c2a12e9d5e 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
if (rf->channel <= 50) {
- rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
+ rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
} else if (rf->channel >= 52) {
rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon
2024-09-20 2:59 [PATCH v1] wifi: rt2x00: convert comma to semicolon Yan Zhen
@ 2024-09-20 9:54 ` Stanislaw Gruszka
2024-10-17 16:46 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Stanislaw Gruszka @ 2024-09-20 9:54 UTC (permalink / raw)
To: Yan Zhen; +Cc: kvalo, linux-wireless, linux-kernel, opensource.kernel
On Fri, Sep 20, 2024 at 10:59:17AM +0800, Yan Zhen wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
> ---
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> index 3bb81bcff0ac..60c2a12e9d5e 100644
> --- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
> @@ -3607,7 +3607,7 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev,
> rt2800_rfcsr_write(rt2x00dev, 52, 0x0C);
> rt2800_rfcsr_write(rt2x00dev, 54, 0xF8);
> if (rf->channel <= 50) {
> - rt2800_rfcsr_write(rt2x00dev, 55, 0x06),
> + rt2800_rfcsr_write(rt2x00dev, 55, 0x06);
> rt2800_rfcsr_write(rt2x00dev, 56, 0xD3);
> } else if (rf->channel >= 52) {
> rt2800_rfcsr_write(rt2x00dev, 55, 0x04);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] wifi: rt2x00: convert comma to semicolon
2024-09-20 2:59 [PATCH v1] wifi: rt2x00: convert comma to semicolon Yan Zhen
2024-09-20 9:54 ` Stanislaw Gruszka
@ 2024-10-17 16:46 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-10-17 16:46 UTC (permalink / raw)
To: Yan Zhen
Cc: stf_xl, linux-wireless, linux-kernel, opensource.kernel, Yan Zhen
Yan Zhen <yanzhen@vivo.com> wrote:
> To ensure code clarity and prevent potential errors, it's advisable
> to employ the ';' as a statement separator, except when ',' are
> intentionally used for specific purposes.
>
> Signed-off-by: Yan Zhen <yanzhen@vivo.com>
> Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
Patch applied to wireless-next.git, thanks.
c8945c8cd41a wifi: rt2x00: convert comma to semicolon
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240920025917.1959932-1-yanzhen@vivo.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-17 16:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-20 2:59 [PATCH v1] wifi: rt2x00: convert comma to semicolon Yan Zhen
2024-09-20 9:54 ` Stanislaw Gruszka
2024-10-17 16:46 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.