From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6
Date: Fri, 20 Sep 2024 11:09:13 -0400 [thread overview]
Message-ID: <20240920110913.66f768d0@SWDEV2.connecttech.local> (raw)
In-Reply-To: <Zu2M5Y_scTkhSyzx@smile.fi.intel.com>
On Fri, 20 Sep 2024 17:55:33 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Sep 20, 2024 at 10:03:23AM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > Replace the custom 93cx6 EEPROM read functions with the eeprom_93cx6
> > driver. This removes duplicate code and improves code readability.
> >
> > exar_ee_read() calls are replaced with eeprom_93cx6_read() or
> > eeprom_93cx6_multiread().
> >
> > Add "select EEPROM_93CX6" to config SERIAL_8250_EXAR to ensure
> > eeprom_93cx6 driver is also compiled when 8250_exar driver is selected.
> >
> > Note: Old exar_ee_read() and associated functions are removed in next
> > patch in this series.
>
> Looks perfect!
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Let's wait for others and CIs to test all this and then after v6.12-rc1
> is out (presumably within ~ten days) rebase your series (as I suggested
> in another reply) and send a v3.
>
Sounds good, I will wait for v6.12-rc1, rebase and send v3 with the
changes you (or others) suggested. I promise I won't forget the Reviewed-by
tags this time :).
> Good work!
>
Thanks and thanks for the help!
-Parker
next prev parent reply other threads:[~2024-09-20 15:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 14:03 [PATCH v2 0/4] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-09-20 14:03 ` [PATCH v2 1/4] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-09-20 14:45 ` Andy Shevchenko
2024-09-20 15:03 ` Parker Newman
2024-09-20 14:48 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 2/4] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-09-20 14:46 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 3/4] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-09-20 14:55 ` Andy Shevchenko
2024-09-20 15:09 ` Parker Newman [this message]
2024-09-20 15:26 ` Andy Shevchenko
2024-09-20 15:42 ` Parker Newman
2024-09-20 15:46 ` Andy Shevchenko
2024-09-20 14:03 ` [PATCH v2 4/4] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-09-20 14:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920110913.66f768d0@SWDEV2.connecttech.local \
--to=parker@finest.io \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.