From: James Raphael Tiovalen <jamestiotio@gmail.com>
To: kvm-riscv@lists.infradead.org
Subject: [kvm-unit-tests PATCH v5 1/5] riscv: Rewrite hartid_to_cpu in assembly
Date: Sat, 21 Sep 2024 18:08:19 +0800 [thread overview]
Message-ID: <20240921100824.151761-2-jamestiotio@gmail.com> (raw)
In-Reply-To: <20240921100824.151761-1-jamestiotio@gmail.com>
From: Andrew Jones <andrew.jones@linux.dev>
Some SBI HSM tests run without a stack being setup so they can't
run C code. Those tests still need to know the corresponding cpuid
for the hartid on which they are running. Give those tests
hartid_to_cpu() by reimplementing it in assembly.
Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
---
lib/riscv/asm-offsets.c | 5 +++++
lib/riscv/setup.c | 10 ----------
riscv/cstart.S | 24 ++++++++++++++++++++++++
3 files changed, 29 insertions(+), 10 deletions(-)
diff --git a/lib/riscv/asm-offsets.c b/lib/riscv/asm-offsets.c
index a2a32438..6c511c14 100644
--- a/lib/riscv/asm-offsets.c
+++ b/lib/riscv/asm-offsets.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
#include <kbuild.h>
#include <elf.h>
+#include <asm/processor.h>
#include <asm/ptrace.h>
#include <asm/smp.h>
@@ -58,5 +59,9 @@ int main(void)
OFFSET(SECONDARY_FUNC, secondary_data, func);
DEFINE(SECONDARY_DATA_SIZE, sizeof(struct secondary_data));
+ OFFSET(THREAD_INFO_CPU, thread_info, cpu);
+ OFFSET(THREAD_INFO_HARTID, thread_info, hartid);
+ DEFINE(THREAD_INFO_SIZE, sizeof(struct thread_info));
+
return 0;
}
diff --git a/lib/riscv/setup.c b/lib/riscv/setup.c
index 495db041..f347ad63 100644
--- a/lib/riscv/setup.c
+++ b/lib/riscv/setup.c
@@ -43,16 +43,6 @@ uint64_t timebase_frequency;
static struct mem_region riscv_mem_regions[NR_MEM_REGIONS + 1];
-int hartid_to_cpu(unsigned long hartid)
-{
- int cpu;
-
- for_each_present_cpu(cpu)
- if (cpus[cpu].hartid == hartid)
- return cpu;
- return -1;
-}
-
static void cpu_set_fdt(int fdtnode __unused, u64 regval, void *info __unused)
{
int cpu = nr_cpus++;
diff --git a/riscv/cstart.S b/riscv/cstart.S
index 8f269997..68717370 100644
--- a/riscv/cstart.S
+++ b/riscv/cstart.S
@@ -109,6 +109,30 @@ halt:
1: wfi
j 1b
+/*
+ * hartid_to_cpu
+ * a0 is a hartid on entry
+ * Returns, in a0, the corresponding cpuid, or -1 if no
+ * thread_info struct with 'hartid' is found.
+ */
+.balign 4
+.global hartid_to_cpu
+hartid_to_cpu:
+ la t0, cpus
+ la t1, nr_cpus
+ lw t1, 0(t1)
+ li t2, 0
+1: bne t2, t1, 2f
+ li a0, -1
+ ret
+2: REG_L t3, THREAD_INFO_HARTID(t0)
+ bne a0, t3, 3f
+ lw a0, THREAD_INFO_CPU(t0)
+ ret
+3: addi t0, t0, THREAD_INFO_SIZE
+ addi t2, t2, 1
+ j 1b
+
.balign 4
.global secondary_entry
secondary_entry:
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: James Raphael Tiovalen <jamestiotio@gmail.com>
To: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org
Cc: andrew.jones@linux.dev, atishp@rivosinc.com,
cade.richard@berkeley.edu,
James Raphael Tiovalen <jamestiotio@gmail.com>
Subject: [kvm-unit-tests PATCH v5 1/5] riscv: Rewrite hartid_to_cpu in assembly
Date: Sat, 21 Sep 2024 18:08:19 +0800 [thread overview]
Message-ID: <20240921100824.151761-2-jamestiotio@gmail.com> (raw)
In-Reply-To: <20240921100824.151761-1-jamestiotio@gmail.com>
From: Andrew Jones <andrew.jones@linux.dev>
Some SBI HSM tests run without a stack being setup so they can't
run C code. Those tests still need to know the corresponding cpuid
for the hartid on which they are running. Give those tests
hartid_to_cpu() by reimplementing it in assembly.
Signed-off-by: Andrew Jones <andrew.jones@linux.dev>
Signed-off-by: James Raphael Tiovalen <jamestiotio@gmail.com>
---
lib/riscv/asm-offsets.c | 5 +++++
lib/riscv/setup.c | 10 ----------
riscv/cstart.S | 24 ++++++++++++++++++++++++
3 files changed, 29 insertions(+), 10 deletions(-)
diff --git a/lib/riscv/asm-offsets.c b/lib/riscv/asm-offsets.c
index a2a32438..6c511c14 100644
--- a/lib/riscv/asm-offsets.c
+++ b/lib/riscv/asm-offsets.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-only
#include <kbuild.h>
#include <elf.h>
+#include <asm/processor.h>
#include <asm/ptrace.h>
#include <asm/smp.h>
@@ -58,5 +59,9 @@ int main(void)
OFFSET(SECONDARY_FUNC, secondary_data, func);
DEFINE(SECONDARY_DATA_SIZE, sizeof(struct secondary_data));
+ OFFSET(THREAD_INFO_CPU, thread_info, cpu);
+ OFFSET(THREAD_INFO_HARTID, thread_info, hartid);
+ DEFINE(THREAD_INFO_SIZE, sizeof(struct thread_info));
+
return 0;
}
diff --git a/lib/riscv/setup.c b/lib/riscv/setup.c
index 495db041..f347ad63 100644
--- a/lib/riscv/setup.c
+++ b/lib/riscv/setup.c
@@ -43,16 +43,6 @@ uint64_t timebase_frequency;
static struct mem_region riscv_mem_regions[NR_MEM_REGIONS + 1];
-int hartid_to_cpu(unsigned long hartid)
-{
- int cpu;
-
- for_each_present_cpu(cpu)
- if (cpus[cpu].hartid == hartid)
- return cpu;
- return -1;
-}
-
static void cpu_set_fdt(int fdtnode __unused, u64 regval, void *info __unused)
{
int cpu = nr_cpus++;
diff --git a/riscv/cstart.S b/riscv/cstart.S
index 8f269997..68717370 100644
--- a/riscv/cstart.S
+++ b/riscv/cstart.S
@@ -109,6 +109,30 @@ halt:
1: wfi
j 1b
+/*
+ * hartid_to_cpu
+ * a0 is a hartid on entry
+ * Returns, in a0, the corresponding cpuid, or -1 if no
+ * thread_info struct with 'hartid' is found.
+ */
+.balign 4
+.global hartid_to_cpu
+hartid_to_cpu:
+ la t0, cpus
+ la t1, nr_cpus
+ lw t1, 0(t1)
+ li t2, 0
+1: bne t2, t1, 2f
+ li a0, -1
+ ret
+2: REG_L t3, THREAD_INFO_HARTID(t0)
+ bne a0, t3, 3f
+ lw a0, THREAD_INFO_CPU(t0)
+ ret
+3: addi t0, t0, THREAD_INFO_SIZE
+ addi t2, t2, 1
+ j 1b
+
.balign 4
.global secondary_entry
secondary_entry:
--
2.43.0
next prev parent reply other threads:[~2024-09-21 10:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 10:08 [kvm-unit-tests PATCH v5 0/5] riscv: sbi: Add support to test HSM extension James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen [this message]
2024-09-21 10:08 ` [kvm-unit-tests PATCH v5 1/5] riscv: Rewrite hartid_to_cpu in assembly James Raphael Tiovalen
2024-09-21 10:08 ` [kvm-unit-tests PATCH v5 2/5] riscv: sbi: Provide entry point for HSM tests James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen
2024-09-21 10:08 ` [kvm-unit-tests PATCH v5 3/5] lib/on-cpus: Add helper method to clear the function from on_cpu_info James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen
2024-09-21 10:08 ` [kvm-unit-tests PATCH v5 4/5] riscv: Add helper method to set cpu started mask James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen
2024-09-21 10:08 ` [kvm-unit-tests PATCH v5 5/5] riscv: sbi: Add tests for HSM extension James Raphael Tiovalen
2024-09-21 10:08 ` James Raphael Tiovalen
2024-10-23 14:23 ` [kvm-unit-tests PATCH v5 0/5] riscv: sbi: Add support to test " Andrew Jones
2024-10-23 14:23 ` Andrew Jones
2024-10-23 14:40 ` James R T
2024-10-23 14:40 ` James R T
2024-11-06 8:44 ` Andrew Jones
2024-11-06 8:44 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240921100824.151761-2-jamestiotio@gmail.com \
--to=jamestiotio@gmail.com \
--cc=kvm-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.