* drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
@ 2024-09-23 19:33 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-09-23 19:33 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Manikandan Muralidharan <manikandan.m@microchip.com>
CC: Sam Ravnborg <sam@ravnborg.org>
CC: Hari Prasath Gujulan Elango <Hari.PrasathGE@microchip.com>
CC: Durai Manickam KR <durai.manickamkr@microchip.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f8eb5bd9a818cc5f2a1e50b22b0091830b28cc36
commit: d498771b0b830140a70cb8118ee0ee522be94f39 drm: atmel_hlcdc: Add support for XLCDC using IP specific driver ops
date: 4 months ago
:::::: branch date: 4 hours ago
:::::: commit date: 4 months ago
config: sparc-randconfig-r071-20240923 (https://download.01.org/0day-ci/archive/20240924/202409240320.MZPgi3Up-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202409240320.MZPgi3Up-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
vim +/sr +573 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
d498771b0b8301 Manikandan Muralidharan 2024-04-24 555
aa71584b323acf Manikandan Muralidharan 2024-04-24 556 static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
aa71584b323acf Manikandan Muralidharan 2024-04-24 557 struct atmel_hlcdc_plane_state *state)
aa71584b323acf Manikandan Muralidharan 2024-04-24 558 {
aa71584b323acf Manikandan Muralidharan 2024-04-24 559 const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
aa71584b323acf Manikandan Muralidharan 2024-04-24 560 struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
aa71584b323acf Manikandan Muralidharan 2024-04-24 561 struct drm_framebuffer *fb = state->base.fb;
aa71584b323acf Manikandan Muralidharan 2024-04-24 562 u32 sr;
aa71584b323acf Manikandan Muralidharan 2024-04-24 563 int i;
aa71584b323acf Manikandan Muralidharan 2024-04-24 564
d498771b0b8301 Manikandan Muralidharan 2024-04-24 565 if (!dc->desc->is_xlcdc)
aa71584b323acf Manikandan Muralidharan 2024-04-24 566 sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
aa71584b323acf Manikandan Muralidharan 2024-04-24 567
aa71584b323acf Manikandan Muralidharan 2024-04-24 568 for (i = 0; i < state->nplanes; i++) {
aa71584b323acf Manikandan Muralidharan 2024-04-24 569 struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
aa71584b323acf Manikandan Muralidharan 2024-04-24 570
aa71584b323acf Manikandan Muralidharan 2024-04-24 571 state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
aa71584b323acf Manikandan Muralidharan 2024-04-24 572
aa71584b323acf Manikandan Muralidharan 2024-04-24 @573 dc->desc->ops->lcdc_update_buffers(plane, state, sr, i);
aa71584b323acf Manikandan Muralidharan 2024-04-24 574
9a45d33cdf82f1 Boris Brezillon 2017-02-06 575 if (desc->layout.xstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 576 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 577 desc->layout.xstride[i],
9a45d33cdf82f1 Boris Brezillon 2017-02-06 578 state->xstride[i]);
9a45d33cdf82f1 Boris Brezillon 2017-02-06 579
9a45d33cdf82f1 Boris Brezillon 2017-02-06 580 if (desc->layout.pstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 581 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 582 desc->layout.pstride[i],
2389fc1305fc1e Boris Brezillon 2015-02-05 583 state->pstride[i]);
1a396789f65a22 Boris Brezillon 2015-01-06 584 }
1a396789f65a22 Boris Brezillon 2015-01-06 585 }
1a396789f65a22 Boris Brezillon 2015-01-06 586
:::::: The code at line 573 was first introduced by commit
:::::: aa71584b323acf62f42844e4f1b4d472b7958a0b drm: atmel-hlcdc: add driver ops to differentiate HLCDC and XLCDC IP
:::::: TO: Manikandan Muralidharan <manikandan.m@microchip.com>
:::::: CC: Sam Ravnborg <sam@ravnborg.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
@ 2024-09-25 10:23 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-09-25 10:23 UTC (permalink / raw)
To: oe-kbuild, Manikandan Muralidharan
Cc: lkp, oe-kbuild-all, linux-kernel, Sam Ravnborg,
Hari Prasath Gujulan Elango, Durai Manickam KR
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f8eb5bd9a818cc5f2a1e50b22b0091830b28cc36
commit: d498771b0b830140a70cb8118ee0ee522be94f39 drm: atmel_hlcdc: Add support for XLCDC using IP specific driver ops
config: sparc-randconfig-r071-20240923 (https://download.01.org/0day-ci/archive/20240924/202409240320.MZPgi3Up-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202409240320.MZPgi3Up-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr'.
vim +/sr +573 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
aa71584b323acf Manikandan Muralidharan 2024-04-24 556 static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
aa71584b323acf Manikandan Muralidharan 2024-04-24 557 struct atmel_hlcdc_plane_state *state)
aa71584b323acf Manikandan Muralidharan 2024-04-24 558 {
aa71584b323acf Manikandan Muralidharan 2024-04-24 559 const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
aa71584b323acf Manikandan Muralidharan 2024-04-24 560 struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
aa71584b323acf Manikandan Muralidharan 2024-04-24 561 struct drm_framebuffer *fb = state->base.fb;
aa71584b323acf Manikandan Muralidharan 2024-04-24 562 u32 sr;
aa71584b323acf Manikandan Muralidharan 2024-04-24 563 int i;
aa71584b323acf Manikandan Muralidharan 2024-04-24 564
d498771b0b8301 Manikandan Muralidharan 2024-04-24 565 if (!dc->desc->is_xlcdc)
aa71584b323acf Manikandan Muralidharan 2024-04-24 566 sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
Uninitialized on else path.
aa71584b323acf Manikandan Muralidharan 2024-04-24 567
aa71584b323acf Manikandan Muralidharan 2024-04-24 568 for (i = 0; i < state->nplanes; i++) {
aa71584b323acf Manikandan Muralidharan 2024-04-24 569 struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
aa71584b323acf Manikandan Muralidharan 2024-04-24 570
aa71584b323acf Manikandan Muralidharan 2024-04-24 571 state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
aa71584b323acf Manikandan Muralidharan 2024-04-24 572
aa71584b323acf Manikandan Muralidharan 2024-04-24 @573 dc->desc->ops->lcdc_update_buffers(plane, state, sr, i);
^^
aa71584b323acf Manikandan Muralidharan 2024-04-24 574
9a45d33cdf82f1 Boris Brezillon 2017-02-06 575 if (desc->layout.xstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 576 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 577 desc->layout.xstride[i],
9a45d33cdf82f1 Boris Brezillon 2017-02-06 578 state->xstride[i]);
9a45d33cdf82f1 Boris Brezillon 2017-02-06 579
9a45d33cdf82f1 Boris Brezillon 2017-02-06 580 if (desc->layout.pstride[i])
9a45d33cdf82f1 Boris Brezillon 2017-02-06 581 atmel_hlcdc_layer_write_cfg(&plane->layer,
9a45d33cdf82f1 Boris Brezillon 2017-02-06 582 desc->layout.pstride[i],
2389fc1305fc1e Boris Brezillon 2015-02-05 583 state->pstride[i]);
1a396789f65a22 Boris Brezillon 2015-01-06 584 }
1a396789f65a22 Boris Brezillon 2015-01-06 585 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-25 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-23 19:33 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:573 atmel_hlcdc_plane_update_buffers() error: uninitialized symbol 'sr' kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-09-25 10:23 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.