Re: [PATCH V1 2/9] iommufd: remove uptr from iopt_alloc_iova

[Jason Gunthorpe <jgg@nvidia.com>]

On Wed, Sep 18, 2024 at 10:51:32AM -0400, Steven Sistare wrote:
> On 9/15/2024 4:41 PM, Jason Gunthorpe wrote:
> > On Sat, Sep 14, 2024 at 06:05:51AM -0700, Steve Sistare wrote:
> > > iopt_alloc_iova takes a uptr argument but only checks for its alignment.
> > > Pass an offset from start instead to eliminate its dependence on a user
> > > address.
> > 
> > An offset from start is a meaningfully different thing for this, it
> > throws away all the information it is trying to extract (is the uptr
> > huge page aligned)
> 
> Interpret offset as "from the start of the address space, eg 0" and it
> works. That was my intent, since I pass offset from the start of the file
> address space in a subsequent patch.  But instead, I can rename uptr to
> to address and describe it this way:
> 
>   iopt_alloc_iova takes a uptr argument but only checks for its alignment.
>   Generalize this to an unsigned address, which will be the offset from the
>   start of a file in a subsequent patch.  No functional change.

Yes that makes sense

Jason