From: Jason Gunthorpe <jgg@nvidia.com>
To: David Hildenbrand <david@redhat.com>
Cc: Steven Sistare <steven.sistare@oracle.com>,
linux-mm@kvack.org, Kevin Tian <kevin.tian@intel.com>,
Nicolin Chen <nicolinc@nvidia.com>,
iommu@lists.linux.dev, Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH V1 1/9] mm/gup: repin_folio_unhugely
Date: Thu, 26 Sep 2024 08:40:00 -0300 [thread overview]
Message-ID: <20240926114000.GW9417@nvidia.com> (raw)
In-Reply-To: <27f8ff84-76cf-40ee-b391-e226218e5600@redhat.com>
On Thu, Sep 26, 2024 at 01:32:09PM +0200, David Hildenbrand wrote:
> On 20.09.24 15:28, Jason Gunthorpe wrote:
> > On Thu, Sep 19, 2024 at 10:11:38AM +0200, David Hildenbrand wrote:
> >
> > > > > And repin is really misleading. We are simply adding more pins to an already pinned one ...
> > > >
> > > > Jason suggests a better name in the other thread.
> > >
> > > I would prefer something that simply adds more pins to an already pinned
> > > folio. Much easier to get.
> >
> > Yes, but also nobody should ever want to do that operation, it should
> > always be part of some kind of "splitting" sort of behavior..
>
> I remember patches from Dave Howells that needed that for O_DIRECT handling.
> Never say never ;)
Wouldn't O_DIRECT be the same splitting thing?
> Adding is much more intuitive than splitting ... just like we add references
> when splitting a THP, using folio_ref_add().
Well, sure, it just seems harder to document so people can use it
properly.
Jason
next prev parent reply other threads:[~2024-09-26 11:40 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 13:05 [PATCH V1 0/9] iommu_ioas_map_file Steve Sistare
2024-09-14 13:05 ` [PATCH V1 1/9] mm/gup: repin_folio_unhugely Steve Sistare
2024-09-14 13:19 ` Steven Sistare
2024-09-17 12:25 ` David Hildenbrand
2024-09-18 14:51 ` Steven Sistare
2024-09-19 8:11 ` David Hildenbrand
2024-09-19 21:06 ` Steven Sistare
2024-09-26 11:38 ` David Hildenbrand
2024-09-20 13:28 ` Jason Gunthorpe
2024-09-26 11:32 ` David Hildenbrand
2024-09-26 11:40 ` Jason Gunthorpe [this message]
2024-09-26 12:57 ` David Hildenbrand
2024-09-26 12:58 ` David Hildenbrand
2024-09-15 20:37 ` Jason Gunthorpe
2024-09-18 14:51 ` Steven Sistare
2024-09-14 13:05 ` [PATCH V1 2/9] iommufd: remove uptr from iopt_alloc_iova Steve Sistare
2024-09-15 20:41 ` Jason Gunthorpe
2024-09-18 14:51 ` Steven Sistare
2024-09-24 19:50 ` Jason Gunthorpe
2024-09-14 13:05 ` [PATCH V1 3/9] iommufd: generalize iopt_pages address Steve Sistare
2024-09-18 14:52 ` Steven Sistare
2024-09-14 13:05 ` [PATCH V1 4/9] iommufd: pfn reader for file mappings Steve Sistare
2024-09-15 20:51 ` Jason Gunthorpe
2024-09-18 14:51 ` Steven Sistare
2024-09-14 13:05 ` [PATCH V1 5/9] iommufd: IOMMU_IOAS_MAP_FILE interface Steve Sistare
2024-09-15 20:52 ` Jason Gunthorpe
2024-09-18 14:51 ` Steven Sistare
2024-09-14 13:05 ` [PATCH V1 6/9] iommufd: IOMMU_IOAS_MAP_FILE implementation Steve Sistare
2024-09-17 1:48 ` kernel test robot
2024-09-14 13:05 ` [PATCH V1 7/9] iommufd: file mappings for mdev Steve Sistare
2024-09-18 14:52 ` Steven Sistare
2024-09-14 13:05 ` [PATCH V1 8/9] iommufd: replace upages_len Steve Sistare
2024-09-14 13:05 ` [PATCH V1 9/9] iommufd: optimize file mapping Steve Sistare
2024-09-15 20:59 ` Jason Gunthorpe
2024-09-18 14:52 ` Steven Sistare
2024-09-14 13:21 ` [PATCH V1 0/9] iommu_ioas_map_file Steven Sistare
2024-09-15 20:30 ` Jason Gunthorpe
2024-09-18 14:52 ` Steven Sistare
2024-09-23 17:33 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926114000.GW9417@nvidia.com \
--to=jgg@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-mm@kvack.org \
--cc=nicolinc@nvidia.com \
--cc=steven.sistare@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.