From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: controller: allow node name to be named slot@*
Date: Tue, 24 Sep 2024 15:28:38 -0500 [thread overview]
Message-ID: <20240924202838.GA276949-robh@kernel.org> (raw)
In-Reply-To: <20240920-topic-amlogic-arm32-upstream-bindings-fixes-convert-meson-mx-sdio-v2-1-5aa8bdfe01af@linaro.org>
On Fri, Sep 20, 2024 at 10:38:03AM +0200, Neil Armstrong wrote:
> In preparation of supporting the mmc-slot subnode, allow
> the nodename to be either mmc@ or mmc-slot@
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 58ae298cd2fc..f797c32ea688 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -20,7 +20,9 @@ description: |
>
> properties:
> $nodename:
> - pattern: "^mmc(@.*)?$"
> + oneOf:
> + - pattern: "^mmc(@.*)?$"
> + - pattern: "^slot(@.*)?$"
'^(mmc|slot)(@.*)?$'
But the description says something else...
In any case, avoiding 'oneOf' when possible makes for better warnings.
Rob
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: controller: allow node name to be named slot@*
Date: Tue, 24 Sep 2024 15:28:38 -0500 [thread overview]
Message-ID: <20240924202838.GA276949-robh@kernel.org> (raw)
In-Reply-To: <20240920-topic-amlogic-arm32-upstream-bindings-fixes-convert-meson-mx-sdio-v2-1-5aa8bdfe01af@linaro.org>
On Fri, Sep 20, 2024 at 10:38:03AM +0200, Neil Armstrong wrote:
> In preparation of supporting the mmc-slot subnode, allow
> the nodename to be either mmc@ or mmc-slot@
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 58ae298cd2fc..f797c32ea688 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -20,7 +20,9 @@ description: |
>
> properties:
> $nodename:
> - pattern: "^mmc(@.*)?$"
> + oneOf:
> + - pattern: "^mmc(@.*)?$"
> + - pattern: "^slot(@.*)?$"
'^(mmc|slot)(@.*)?$'
But the description says something else...
In any case, avoiding 'oneOf' when possible makes for better warnings.
Rob
next prev parent reply other threads:[~2024-09-24 20:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 8:38 [PATCH v2 0/3] dt-bindings: mmc: document mmc-slot and convert amlogic,meson-mx-sdio.txt to dtschema Neil Armstrong
2024-09-20 8:38 ` Neil Armstrong
2024-09-20 8:38 ` [PATCH v2 1/3] dt-bindings: mmc: controller: allow node name to be named slot@* Neil Armstrong
2024-09-20 8:38 ` Neil Armstrong
2024-09-24 9:12 ` Krzysztof Kozlowski
2024-09-24 9:12 ` Krzysztof Kozlowski
2024-10-07 9:00 ` Neil Armstrong
2024-10-07 9:00 ` Neil Armstrong
2024-09-24 20:28 ` Rob Herring [this message]
2024-09-24 20:28 ` Rob Herring
2024-09-20 8:38 ` [PATCH v2 2/3] dt-bindings: mmc: document mmc-slot Neil Armstrong
2024-09-20 8:38 ` Neil Armstrong
2024-09-24 9:15 ` Krzysztof Kozlowski
2024-09-24 9:15 ` Krzysztof Kozlowski
2024-10-07 8:57 ` Neil Armstrong
2024-10-07 8:57 ` Neil Armstrong
2024-09-24 20:30 ` Rob Herring
2024-09-24 20:30 ` Rob Herring
2024-09-20 8:38 ` [PATCH v2 3/3] dt-bindings: mmc: convert amlogic,meson-mx-sdio.txt to dtschema Neil Armstrong
2024-09-20 8:38 ` Neil Armstrong
2024-09-24 9:18 ` Krzysztof Kozlowski
2024-09-24 9:18 ` Krzysztof Kozlowski
2024-09-25 17:29 ` Martin Blumenstingl
2024-09-25 17:29 ` Martin Blumenstingl
2024-09-25 19:31 ` Krzysztof Kozlowski
2024-09-25 19:31 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924202838.GA276949-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.