* [openeuler:OLK-5.10 23318/30000] drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
@ 2024-09-24 20:55 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-09-24 20:55 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Dan Carpenter
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: kernel@openeuler.org
TO: Yingbao Jia <yingbao.jia@intel.com>
tree: https://gitee.com/openeuler/kernel.git OLK-5.10
head: ef5e9d0437237465f258a80a0d5d8e1e26872c7a
commit: 4dc4d762dd6ed4cb851209a87e79d7d936b3fb4c [23318/30000] platform/x86: ISST: Enumerate TPMI SST and create framework
:::::: branch date: 7 hours ago
:::::: commit date: 8 months ago
config: x86_64-randconfig-161-20240925 (https://download.01.org/0day-ci/archive/20240925/202409250439.RGKHfbdX-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202409250439.RGKHfbdX-lkp@intel.com/
smatch warnings:
drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:104 isst_if_get_tpmi_instance_count() warn: possible spectre second half. 'sst_inst'
vim +100 drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 87
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 88 static int isst_if_get_tpmi_instance_count(void __user *argp)
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 89 {
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 90 struct isst_tpmi_instance_count tpmi_inst;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 91 struct tpmi_sst_struct *sst_inst;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 92 int i;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 93
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 94 if (copy_from_user(&tpmi_inst, argp, sizeof(tpmi_inst)))
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 95 return -EFAULT;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 96
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 97 if (tpmi_inst.socket_id >= topology_max_packages())
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 98 return -EINVAL;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 99
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 @100 tpmi_inst.count = isst_common.sst_inst[tpmi_inst.socket_id]->number_of_power_domains;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 101
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 102 sst_inst = isst_common.sst_inst[tpmi_inst.socket_id];
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 103 tpmi_inst.valid_mask = 0;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 @104 for (i = 0; i < sst_inst->number_of_power_domains; ++i) {
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 105 struct tpmi_per_power_domain_info *power_domain_info;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 106
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 107 power_domain_info = &sst_inst->power_domain_info[i];
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 108 if (power_domain_info->sst_base)
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 109 tpmi_inst.valid_mask |= BIT(i);
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 110 }
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 111
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 112 if (copy_to_user(argp, &tpmi_inst, sizeof(tpmi_inst)))
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 113 return -EFAULT;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 114
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 115 return 0;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 116 }
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 117
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [openeuler:OLK-5.10 23318/30000] drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
@ 2024-09-25 11:19 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2024-09-25 11:19 UTC (permalink / raw)
To: oe-kbuild, kernel, Yingbao Jia, Dan Williams; +Cc: lkp, oe-kbuild-all
tree: https://gitee.com/openeuler/kernel.git OLK-5.10
head: ef5e9d0437237465f258a80a0d5d8e1e26872c7a
commit: 4dc4d762dd6ed4cb851209a87e79d7d936b3fb4c [23318/30000] platform/x86: ISST: Enumerate TPMI SST and create framework
config: x86_64-randconfig-161-20240925 (https://download.01.org/0day-ci/archive/20240925/202409250439.RGKHfbdX-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202409250439.RGKHfbdX-lkp@intel.com/
smatch warnings:
drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap)
drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:104 isst_if_get_tpmi_instance_count() warn: possible spectre second half. 'sst_inst'
vim +100 drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 88 static int isst_if_get_tpmi_instance_count(void __user *argp)
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 89 {
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 90 struct isst_tpmi_instance_count tpmi_inst;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 91 struct tpmi_sst_struct *sst_inst;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 92 int i;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 93
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 94 if (copy_from_user(&tpmi_inst, argp, sizeof(tpmi_inst)))
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 95 return -EFAULT;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 96
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 97 if (tpmi_inst.socket_id >= topology_max_packages())
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 98 return -EINVAL;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 99
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 @100 tpmi_inst.count = isst_common.sst_inst[tpmi_inst.socket_id]->number_of_power_domains;
I believe this is a case where we need to use array_index_nospec(). But you
work for Intel so I'm sure there are experts you could ask. ;) Let me know
either way so I can learn from this.
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 101
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 102 sst_inst = isst_common.sst_inst[tpmi_inst.socket_id];
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 103 tpmi_inst.valid_mask = 0;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 @104 for (i = 0; i < sst_inst->number_of_power_domains; ++i) {
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 105 struct tpmi_per_power_domain_info *power_domain_info;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 106
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 107 power_domain_info = &sst_inst->power_domain_info[i];
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 108 if (power_domain_info->sst_base)
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 109 tpmi_inst.valid_mask |= BIT(i);
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 110 }
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 111
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 112 if (copy_to_user(argp, &tpmi_inst, sizeof(tpmi_inst)))
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 113 return -EFAULT;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 114
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 115 return 0;
4dc4d762dd6ed4 Srinivas Pandruvada 2023-03-07 116 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-25 11:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 20:55 [openeuler:OLK-5.10 23318/30000] drivers/platform/x86/intel_speed_select_if/isst_tpmi_core.c:100 isst_if_get_tpmi_instance_count() warn: potential spectre issue 'isst_common.sst_inst' [r] (local cap) kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-09-25 11:19 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.