Re: [RFC PATCH 3/4] block: add support for partition table defined in OF

[kernel test robot <lkp@intel.com>]

Hi Christian,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on robh/for-next lwn/docs-next linus/master v6.11 next-20240925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Marangi/block-add-support-for-defining-read-only-partitions/20240923-190251
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20240923105937.4374-4-ansuelsmth%40gmail.com
patch subject: [RFC PATCH 3/4] block: add support for partition table defined in OF
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240925/202409251428.jWKG05TG-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409251428.jWKG05TG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409251428.jWKG05TG-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   block/partitions/of.c: In function 'add_of_partition':
>> block/partitions/of.c:47:35: error: 'pp' undeclared (first use in this function); did you mean 'np'?
      47 |         if (of_property_read_bool(pp, "read-only"))
         |                                   ^~
         |                                   np
   block/partitions/of.c:47:35: note: each undeclared identifier is reported only once for each function it appears in
   block/partitions/of.c: At top level:
>> block/partitions/of.c:58:5: warning: no previous prototype for 'of_partition' [-Wmissing-prototypes]
      58 | int of_partition(struct parsed_partitions *state)
         |     ^~~~~~~~~~~~


vim +47 block/partitions/of.c

    25	
    26	static void add_of_partition(struct parsed_partitions *state, int slot,
    27				     struct device_node *np)
    28	{
    29		struct partition_meta_info *info;
    30		char tmp[sizeof(info->volname) + 4];
    31		int a_cells, s_cells;
    32		const char *partname;
    33		const __be32 *reg;
    34		u64 offset, size;
    35		int len;
    36	
    37		reg = of_get_property(np, "reg", &len);
    38	
    39		a_cells = of_n_addr_cells(np);
    40		s_cells = of_n_size_cells(np);
    41	
    42		offset = of_read_number(reg, a_cells);
    43		size = of_read_number(reg + a_cells, s_cells);
    44	
    45		put_partition(state, slot, offset, size);
    46	
  > 47		if (of_property_read_bool(pp, "read-only"))
    48			state->parts[slot].flags |= ADDPART_FLAG_READONLY;
    49	
    50		info = &state->parts[slot].info;
    51		partname = of_get_property(np, "label", &len);
    52		strscpy(info->volname, partname, sizeof(info->volname));
    53	
    54		snprintf(tmp, sizeof(tmp), "(%s)", info->volname);
    55		strlcat(state->pp_buf, tmp, PAGE_SIZE);
    56	}
    57	
  > 58	int of_partition(struct parsed_partitions *state)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki