From: Christoph Hellwig <hch@infradead.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Jonathan Corbet <corbet@lwn.net>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
INAGAKI Hiroshi <musashino.open@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Ming Lei <ming.lei@redhat.com>,
Li Lingfeng <lilingfeng3@huawei.com>,
Christian Heusel <christian@heusel.eu>,
linux-block@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org,
Miquel Raynal <miquel.raynal@bootlin.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [RFC PATCH 3/4] block: add support for partition table defined in OF
Date: Mon, 23 Sep 2024 23:34:53 -0700 [thread overview]
Message-ID: <ZvJdjRpFaPUuFhIO@infradead.org> (raw)
In-Reply-To: <20240923105937.4374-4-ansuelsmth@gmail.com>
On Mon, Sep 23, 2024 at 12:59:32PM +0200, Christian Marangi wrote:
> +#define BOOT0_STR "boot0"
> +#define BOOT1_STR "boot1"
> +
This boot0/1 stuff looks like black magic, so it should probably be
documented at very least.
> + partitions_np = get_partitions_node(disk_np,
> + state->disk->disk_name);
disk->disk_name is not a stable identifier and can change from boot to
boot due to async probing. You'll need to check a uuid or label instead.
next prev parent reply other threads:[~2024-09-24 6:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 10:59 [RFC PATCH 0/4] block: partition table OF support Christian Marangi
2024-09-23 10:59 ` [RFC PATCH 1/4] block: add support for defining read-only partitions Christian Marangi
2024-09-24 6:32 ` Christoph Hellwig
2024-09-23 10:59 ` [RFC PATCH 2/4] docs: block: Document support for read-only partition in cmdline part Christian Marangi
2024-09-23 10:59 ` [RFC PATCH 3/4] block: add support for partition table defined in OF Christian Marangi
2024-09-24 6:34 ` Christoph Hellwig [this message]
2024-09-24 10:17 ` Christian Marangi
2024-10-01 8:37 ` Christoph Hellwig
2024-10-01 9:26 ` Christian Marangi
2024-10-02 7:45 ` Christoph Hellwig
2024-10-02 8:22 ` Christian Marangi
2024-09-25 6:32 ` kernel test robot
2024-09-25 7:54 ` kernel test robot
2024-09-23 10:59 ` [RFC PATCH 4/4] dt-bindings: mmc: Document support for partition table in mmc-card Christian Marangi
2024-09-24 22:53 ` Rob Herring
2024-09-24 23:01 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvJdjRpFaPUuFhIO@infradead.org \
--to=hch@infradead.org \
--cc=ansuelsmth@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=christian@heusel.eu \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ming.lei@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=musashino.open@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.