From: Simon Horman <horms@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code napi_struct size
Date: Wed, 25 Sep 2024 21:33:24 +0100 [thread overview]
Message-ID: <20240925203324.GD4029621@kernel.org> (raw)
In-Reply-To: <20240925180017.82891-2-jdamato@fastly.com>
On Wed, Sep 25, 2024 at 06:00:17PM +0000, Joe Damato wrote:
> The sizeof(struct napi_struct) can change. Don't hardcode the size to
> 400 bytes and instead use "sizeof(struct napi_struct)".
>
> While fixing this, also move other calculations into compile time
> defines.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC net-next 1/1] idpf: Don't hard code napi_struct size
Date: Wed, 25 Sep 2024 21:33:24 +0100 [thread overview]
Message-ID: <20240925203324.GD4029621@kernel.org> (raw)
In-Reply-To: <20240925180017.82891-2-jdamato@fastly.com>
On Wed, Sep 25, 2024 at 06:00:17PM +0000, Joe Damato wrote:
> The sizeof(struct napi_struct) can change. Don't hardcode the size to
> 400 bytes and instead use "sizeof(struct napi_struct)".
>
> While fixing this, also move other calculations into compile time
> defines.
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-09-25 20:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:00 [Intel-wired-lan] [RFC net-next 0/1] idpf: Don't hardcode napi_struct size Joe Damato
2024-09-25 18:00 ` Joe Damato
2024-09-25 18:00 ` [Intel-wired-lan] [RFC net-next 1/1] idpf: Don't hard code " Joe Damato
2024-09-25 18:00 ` Joe Damato
2024-09-25 20:33 ` Simon Horman [this message]
2024-09-25 20:33 ` Simon Horman
2024-09-30 12:33 ` [Intel-wired-lan] " Alexander Lobakin
2024-09-30 12:33 ` Alexander Lobakin
2024-09-30 12:38 ` [Intel-wired-lan] " Alexander Lobakin
2024-09-30 12:38 ` Alexander Lobakin
2024-09-30 13:10 ` [Intel-wired-lan] " Przemek Kitszel
2024-09-30 13:10 ` Przemek Kitszel
2024-09-30 22:17 ` [Intel-wired-lan] " Joe Damato
2024-09-30 22:17 ` Joe Damato
2024-10-01 13:14 ` [Intel-wired-lan] " Alexander Lobakin
2024-10-01 13:14 ` Alexander Lobakin
2024-10-01 14:44 ` [Intel-wired-lan] " Joe Damato
2024-10-01 14:44 ` Joe Damato
2024-10-02 17:17 ` [Intel-wired-lan] " Jakub Kicinski
2024-10-02 17:17 ` Jakub Kicinski
2024-10-03 13:35 ` [Intel-wired-lan] " Alexander Lobakin
2024-10-03 13:35 ` Alexander Lobakin
2024-10-03 15:46 ` [Intel-wired-lan] " Joe Damato
2024-10-03 15:46 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925203324.GD4029621@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.