From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <kees@kernel.org>
Cc: Vegard Nossum <vegard.nossum@oracle.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Allen Pais <apais@linux.microsoft.com>,
Roman Kisel <romank@linux.microsoft.com>,
Xiaoming Ni <nixiaoming@huawei.com>,
Vijay Nag <nagvijay@microsoft.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] coredump: Do not lock during 'comm' reporting
Date: Sat, 28 Sep 2024 14:35:32 -0700 [thread overview]
Message-ID: <20240928143532.39559729f9eceee468358abe@linux-foundation.org> (raw)
In-Reply-To: <20240928210830.work.307-kees@kernel.org>
On Sat, 28 Sep 2024 14:08:31 -0700 Kees Cook <kees@kernel.org> wrote:
> The 'comm' member will always be NUL terminated,
Why is this? I thought this is only true if the caller holds task_lock()?
> and this is not
> fast-path, so we can just perform a direct memcpy during a coredump
> instead of potentially deadlocking while holding the task struct lock.
>
next prev parent reply other threads:[~2024-09-28 21:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 21:08 [PATCH] coredump: Do not lock during 'comm' reporting Kees Cook
2024-09-28 21:35 ` Andrew Morton [this message]
2024-09-28 21:39 ` Kees Cook
2024-09-28 21:46 ` Andrew Morton
2024-09-28 21:51 ` Kees Cook
2024-09-29 18:42 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240928143532.39559729f9eceee468358abe@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apais@linux.microsoft.com \
--cc=ebiederm@xmission.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nagvijay@microsoft.com \
--cc=nixiaoming@huawei.com \
--cc=romank@linux.microsoft.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.