From: Paul Barker <paul@pbarker.dev>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Paul Barker" <paul.barker.ct@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [net-next PATCH 04/11] net: ravb: Combine if conditions in RX csum validation
Date: Mon, 30 Sep 2024 17:08:38 +0100 [thread overview]
Message-ID: <20240930160845.8520-5-paul@pbarker.dev> (raw)
In-Reply-To: <20240930160845.8520-1-paul@pbarker.dev>
From: Paul Barker <paul.barker.ct@bp.renesas.com>
We can merge the two if conditions on skb_is_nonlinear(). Since
skb_frag_size_sub() and skb_trim() do not free memory, it is still safe
to access the trimmed bytes at the end of the packet after these calls.
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
---
drivers/net/ethernet/renesas/ravb_main.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index f3913c164161..1dd2152734b0 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -769,18 +769,15 @@ static void ravb_rx_csum_gbeth(struct sk_buff *skb)
last_frag = &shinfo->frags[shinfo->nr_frags - 1];
hw_csum = skb_frag_address(last_frag) +
skb_frag_size(last_frag);
+ skb_frag_size_sub(last_frag, 2 * sizeof(__sum16));
} else {
hw_csum = skb_tail_pointer(skb);
+ skb_trim(skb, skb->len - 2 * sizeof(__sum16));
}
hw_csum -= sizeof(__sum16);
csum_proto = csum_unfold((__force __sum16)get_unaligned_le16(hw_csum));
- if (skb_is_nonlinear(skb))
- skb_frag_size_sub(last_frag, 2 * sizeof(__sum16));
- else
- skb_trim(skb, skb->len - 2 * sizeof(__sum16));
-
if (!csum_proto)
skb->ip_summed = CHECKSUM_UNNECESSARY;
}
--
2.43.0
next prev parent reply other threads:[~2024-09-30 16:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:08 [net-next PATCH 00/11] Extend GbEth checksum offload support to VLAN/IPv6 packets Paul Barker
2024-09-30 16:08 ` [net-next PATCH 01/11] net: ravb: Factor out checksum offload enable bits Paul Barker
2024-09-30 17:02 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 02/11] net: ravb: Disable IP header RX checksum offloading Paul Barker
2024-09-30 17:16 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 03/11] net: ravb: Drop IP protocol check from RX csum verification Paul Barker
2024-09-30 17:29 ` Sergey Shtylyov
2024-09-30 16:08 ` Paul Barker [this message]
2024-09-30 17:40 ` [net-next PATCH 04/11] net: ravb: Combine if conditions in RX csum validation Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 05/11] net: ravb: Simplify types " Paul Barker
2024-09-30 19:11 ` Sergey Shtylyov
2024-09-30 19:30 ` Sergey Shtylyov
2024-10-03 9:23 ` Paul Barker
2024-10-03 13:20 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 06/11] net: ravb: Disable IP header TX checksum offloading Paul Barker
2024-09-30 19:23 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 07/11] net: ravb: Simplify UDP TX checksum offload Paul Barker
2024-09-30 19:39 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 08/11] net: ravb: Support ICMP TX checksum offload for GbEth Paul Barker
2024-09-30 19:48 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 09/11] net: ravb: Enable IPv6 RX checksum offloading " Paul Barker
2024-09-30 19:55 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 10/11] net: ravb: Enable IPv6 TX checksum offload " Paul Barker
2024-09-30 20:08 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 11/11] net: ravb: Add VLAN checksum support Paul Barker
2024-09-30 20:36 ` Sergey Shtylyov
2024-09-30 22:32 ` Sergey Shtylyov
2024-10-01 10:44 ` Simon Horman
2024-10-02 15:27 ` Sergey Shtylyov
2024-10-03 10:26 ` Paul Barker
2024-10-01 16:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930160845.8520-5-paul@pbarker.dev \
--to=paul@pbarker.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.