From: Paul Barker <paul@pbarker.dev>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: "Paul Barker" <paul.barker.ct@bp.renesas.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Claudiu Beznea" <claudiu.beznea.uj@bp.renesas.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [net-next PATCH 06/11] net: ravb: Disable IP header TX checksum offloading
Date: Mon, 30 Sep 2024 17:08:40 +0100 [thread overview]
Message-ID: <20240930160845.8520-7-paul@pbarker.dev> (raw)
In-Reply-To: <20240930160845.8520-1-paul@pbarker.dev>
From: Paul Barker <paul.barker.ct@bp.renesas.com>
For IPv4 packets, the header checksum will always be calculated in software
in the TX path (Documentation/networking/checksum-offloads.rst says "No
offloading of the IP header checksum is performed; it is always done in
software.") so there is no advantage in asking the hardware to also
calculate this checksum.
Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com>
---
drivers/net/ethernet/renesas/ravb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
index 98496aa39f3d..a5b4f4fe77b1 100644
--- a/drivers/net/ethernet/renesas/ravb.h
+++ b/drivers/net/ethernet/renesas/ravb.h
@@ -998,7 +998,7 @@ enum CSR1_BIT {
CSR1_TDHD = 0x08000000,
};
-#define CSR1_CSUM_ENABLE (CSR1_TIP4 | CSR1_TTCP4 | CSR1_TUDP4)
+#define CSR1_CSUM_ENABLE (CSR1_TTCP4 | CSR1_TUDP4)
enum CSR2_BIT {
CSR2_RIP4 = 0x00000001,
--
2.43.0
next prev parent reply other threads:[~2024-09-30 16:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:08 [net-next PATCH 00/11] Extend GbEth checksum offload support to VLAN/IPv6 packets Paul Barker
2024-09-30 16:08 ` [net-next PATCH 01/11] net: ravb: Factor out checksum offload enable bits Paul Barker
2024-09-30 17:02 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 02/11] net: ravb: Disable IP header RX checksum offloading Paul Barker
2024-09-30 17:16 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 03/11] net: ravb: Drop IP protocol check from RX csum verification Paul Barker
2024-09-30 17:29 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 04/11] net: ravb: Combine if conditions in RX csum validation Paul Barker
2024-09-30 17:40 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 05/11] net: ravb: Simplify types " Paul Barker
2024-09-30 19:11 ` Sergey Shtylyov
2024-09-30 19:30 ` Sergey Shtylyov
2024-10-03 9:23 ` Paul Barker
2024-10-03 13:20 ` Sergey Shtylyov
2024-09-30 16:08 ` Paul Barker [this message]
2024-09-30 19:23 ` [net-next PATCH 06/11] net: ravb: Disable IP header TX checksum offloading Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 07/11] net: ravb: Simplify UDP TX checksum offload Paul Barker
2024-09-30 19:39 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 08/11] net: ravb: Support ICMP TX checksum offload for GbEth Paul Barker
2024-09-30 19:48 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 09/11] net: ravb: Enable IPv6 RX checksum offloading " Paul Barker
2024-09-30 19:55 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 10/11] net: ravb: Enable IPv6 TX checksum offload " Paul Barker
2024-09-30 20:08 ` Sergey Shtylyov
2024-09-30 16:08 ` [net-next PATCH 11/11] net: ravb: Add VLAN checksum support Paul Barker
2024-09-30 20:36 ` Sergey Shtylyov
2024-09-30 22:32 ` Sergey Shtylyov
2024-10-01 10:44 ` Simon Horman
2024-10-02 15:27 ` Sergey Shtylyov
2024-10-03 10:26 ` Paul Barker
2024-10-01 16:46 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930160845.8520-7-paul@pbarker.dev \
--to=paul@pbarker.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=pabeni@redhat.com \
--cc=paul.barker.ct@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.