From: Simon Horman <horms@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs
Date: Tue, 1 Oct 2024 11:50:16 +0100 [thread overview]
Message-ID: <20241001105016.GL1310185@kernel.org> (raw)
In-Reply-To: <20240930171232.1668-2-jdamato@fastly.com>
On Mon, Sep 30, 2024 at 05:12:31PM +0000, Joe Damato wrote:
> Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue
> information.
>
> After this patch is applied, note the IRQs assigned to my NIC:
>
> $ cat /proc/interrupts | grep ens | cut -f1 --delimiter=':'
> 50
> 51
> 52
>
> While e1000e allocates 3 IRQs (RX, TX, and other), it looks like e1000e
> only has a single NAPI, so I've associated the NAPI with the RX IRQ (50
> on my system, seen above).
>
> Note the output from the cli:
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'id': 145, 'ifindex': 2, 'irq': 50}]
>
> This device supports only 1 rx and 1 tx queue. so querying that:
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump queue-get --json='{"ifindex": 2}'
> [{'id': 0, 'ifindex': 2, 'napi-id': 145, 'type': 'rx'},
> {'id': 0, 'ifindex': 2, 'napi-id': 145, 'type': 'tx'}]
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs
Date: Tue, 1 Oct 2024 11:50:16 +0100 [thread overview]
Message-ID: <20241001105016.GL1310185@kernel.org> (raw)
In-Reply-To: <20240930171232.1668-2-jdamato@fastly.com>
On Mon, Sep 30, 2024 at 05:12:31PM +0000, Joe Damato wrote:
> Add support for netdev-genl, allowing users to query IRQ, NAPI, and queue
> information.
>
> After this patch is applied, note the IRQs assigned to my NIC:
>
> $ cat /proc/interrupts | grep ens | cut -f1 --delimiter=':'
> 50
> 51
> 52
>
> While e1000e allocates 3 IRQs (RX, TX, and other), it looks like e1000e
> only has a single NAPI, so I've associated the NAPI with the RX IRQ (50
> on my system, seen above).
>
> Note the output from the cli:
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump napi-get --json='{"ifindex": 2}'
> [{'id': 145, 'ifindex': 2, 'irq': 50}]
>
> This device supports only 1 rx and 1 tx queue. so querying that:
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump queue-get --json='{"ifindex": 2}'
> [{'id': 0, 'ifindex': 2, 'napi-id': 145, 'type': 'rx'},
> {'id': 0, 'ifindex': 2, 'napi-id': 145, 'type': 'tx'}]
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-10-01 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:12 [Intel-wired-lan] [net-next v3 0/2] e1000/e1000e: Link IRQs, NAPIs, and queues Joe Damato
2024-09-30 17:12 ` Joe Damato
2024-09-30 17:12 ` [Intel-wired-lan] [net-next v3 1/2] e1000e: Link NAPI instances to queues and IRQs Joe Damato
2024-09-30 17:12 ` Joe Damato
2024-10-01 10:50 ` Simon Horman [this message]
2024-10-01 10:50 ` Simon Horman
2024-10-01 17:14 ` [Intel-wired-lan] " Lifshits, Vitaly
2024-10-08 13:45 ` Avigail Dahan
2024-10-08 13:45 ` Avigail Dahan
2024-09-30 17:12 ` [Intel-wired-lan] [net-next v3 2/2] e1000: " Joe Damato
2024-09-30 17:12 ` Joe Damato
2024-10-01 10:50 ` [Intel-wired-lan] " Simon Horman
2024-10-01 10:50 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001105016.GL1310185@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.