* [android-common:android11-kiwi-5.4 1/2] drivers/virtio/virtio_pvclock.c:48:6: sparse: sparse: symbol 'update_suspend_time' was not declared. Should it be static?
@ 2024-07-21 23:03 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-07-21 23:03 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android11-kiwi-5.4
head: 1386767cf46d3f5556ed81a7fe8736520d0cf6c4
commit: 04f660d6724f5df1b07f8cf9e1c55f70fb43d1d2 [1/2] ANDROID: virtio: virtio_pvclock: initial driver impl
config: i386-randconfig-r111-20240722 (https://download.01.org/0day-ci/archive/20240722/202407220641.riLTyn05-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240722/202407220641.riLTyn05-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407220641.riLTyn05-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/virtio/virtio_pvclock.c:294:9: sparse: sparse: mixing declarations and code
>> drivers/virtio/virtio_pvclock.c:48:6: sparse: sparse: symbol 'update_suspend_time' was not declared. Should it be static?
vim +/update_suspend_time +48 drivers/virtio/virtio_pvclock.c
47
> 48 void update_suspend_time(struct work_struct *work)
49 {
50 u64 suspend_ns, suspend_time_delta = 0;
51 struct timespec64 inject_time;
52 struct virtio_pvclock *vp;
53
54 vp = container_of(work, struct virtio_pvclock,
55 update_suspend_time_work);
56
57 virtio_cread(vp->vdev, struct virtio_pvclock_config, suspend_time_ns,
58 &suspend_ns);
59
60 mutex_lock(&vp->inject_suspend_lock);
61 if (suspend_ns > vp->injected_suspend_ns) {
62 suspend_time_delta = suspend_ns - vp->injected_suspend_ns;
63 vp->injected_suspend_ns = suspend_ns;
64 }
65 mutex_unlock(&vp->inject_suspend_lock);
66
67 if (suspend_time_delta == 0) {
68 dev_err(&vp->vdev->dev,
69 "%s: suspend_time_ns is less than injected_suspend_ns\n",
70 __func__);
71 return;
72 }
73
74 inject_time = ns_to_timespec64(suspend_time_delta);
75
76 timekeeping_inject_sleeptime64(&inject_time);
77
78 dev_info(&vp->vdev->dev, "injected sleeptime: %llu ns\n",
79 suspend_time_delta);
80 }
81
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* [android-common:android11-kiwi-5.4 1/2] drivers/virtio/virtio_pvclock.c:48:6: sparse: sparse: symbol 'update_suspend_time' was not declared. Should it be static?
@ 2024-10-01 5:50 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-10-01 5:50 UTC (permalink / raw)
To: cros-kernel-buildreports; +Cc: oe-kbuild-all
tree: https://android.googlesource.com/kernel/common android11-kiwi-5.4
head: 1dd4a498c91aa13a5f4e61fd40a88aebb5bca367
commit: 04f660d6724f5df1b07f8cf9e1c55f70fb43d1d2 [1/2] ANDROID: virtio: virtio_pvclock: initial driver impl
config: i386-randconfig-061-20241001 (https://download.01.org/0day-ci/archive/20241001/202410011350.AXIF805p-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/202410011350.AXIF805p-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410011350.AXIF805p-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
drivers/virtio/virtio_pvclock.c:294:9: sparse: sparse: mixing declarations and code
>> drivers/virtio/virtio_pvclock.c:48:6: sparse: sparse: symbol 'update_suspend_time' was not declared. Should it be static?
vim +/update_suspend_time +48 drivers/virtio/virtio_pvclock.c
47
> 48 void update_suspend_time(struct work_struct *work)
49 {
50 u64 suspend_ns, suspend_time_delta = 0;
51 struct timespec64 inject_time;
52 struct virtio_pvclock *vp;
53
54 vp = container_of(work, struct virtio_pvclock,
55 update_suspend_time_work);
56
57 virtio_cread(vp->vdev, struct virtio_pvclock_config, suspend_time_ns,
58 &suspend_ns);
59
60 mutex_lock(&vp->inject_suspend_lock);
61 if (suspend_ns > vp->injected_suspend_ns) {
62 suspend_time_delta = suspend_ns - vp->injected_suspend_ns;
63 vp->injected_suspend_ns = suspend_ns;
64 }
65 mutex_unlock(&vp->inject_suspend_lock);
66
67 if (suspend_time_delta == 0) {
68 dev_err(&vp->vdev->dev,
69 "%s: suspend_time_ns is less than injected_suspend_ns\n",
70 __func__);
71 return;
72 }
73
74 inject_time = ns_to_timespec64(suspend_time_delta);
75
76 timekeeping_inject_sleeptime64(&inject_time);
77
78 dev_info(&vp->vdev->dev, "injected sleeptime: %llu ns\n",
79 suspend_time_delta);
80 }
81
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-01 5:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-01 5:50 [android-common:android11-kiwi-5.4 1/2] drivers/virtio/virtio_pvclock.c:48:6: sparse: sparse: symbol 'update_suspend_time' was not declared. Should it be static? kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-07-21 23:03 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.