* [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers
@ 2024-10-03 15:48 Andy Shevchenko
2024-10-03 16:03 ` Mika Westerberg
2024-10-07 9:42 ` Ilpo Järvinen
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-10-03 15:48 UTC (permalink / raw)
To: Hans de Goede, Andy Shevchenko, linux-kernel, platform-driver-x86
Cc: Andy Shevchenko, Mika Westerberg, Ilpo Järvinen
Update header inclusions to follow IWYU (Include What You Use)
principle.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/platform_data/x86/intel_scu_ipc.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/linux/platform_data/x86/intel_scu_ipc.h b/include/linux/platform_data/x86/intel_scu_ipc.h
index 0ca9962e97f2..b287627759f7 100644
--- a/include/linux/platform_data/x86/intel_scu_ipc.h
+++ b/include/linux/platform_data/x86/intel_scu_ipc.h
@@ -2,9 +2,13 @@
#ifndef __PLATFORM_X86_INTEL_SCU_IPC_H_
#define __PLATFORM_X86_INTEL_SCU_IPC_H_
+#include <linux/init.h>
#include <linux/ioport.h>
+#include <linux/types.h>
struct device;
+struct module;
+
struct intel_scu_ipc_dev;
/**
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers
2024-10-03 15:48 [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers Andy Shevchenko
@ 2024-10-03 16:03 ` Mika Westerberg
2024-10-03 17:03 ` Andy Shevchenko
2024-10-07 9:42 ` Ilpo Järvinen
1 sibling, 1 reply; 4+ messages in thread
From: Mika Westerberg @ 2024-10-03 16:03 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Hans de Goede, linux-kernel, platform-driver-x86, Andy Shevchenko,
Ilpo Järvinen
On Thu, Oct 03, 2024 at 06:48:19PM +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
Is this some new Coding Style thing?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Fine by me,
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers
2024-10-03 16:03 ` Mika Westerberg
@ 2024-10-03 17:03 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2024-10-03 17:03 UTC (permalink / raw)
To: Mika Westerberg
Cc: Andy Shevchenko, Hans de Goede, linux-kernel, platform-driver-x86,
Andy Shevchenko, Ilpo Järvinen
On Thu, Oct 3, 2024 at 7:03 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> On Thu, Oct 03, 2024 at 06:48:19PM +0300, Andy Shevchenko wrote:
> > Update header inclusions to follow IWYU (Include What You Use)
> > principle.
>
> Is this some new Coding Style thing?
It's useful to unravel a tangle of the dependency hell. Yet it needs
to be documented.
> Fine by me,
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers
2024-10-03 15:48 [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers Andy Shevchenko
2024-10-03 16:03 ` Mika Westerberg
@ 2024-10-07 9:42 ` Ilpo Järvinen
1 sibling, 0 replies; 4+ messages in thread
From: Ilpo Järvinen @ 2024-10-07 9:42 UTC (permalink / raw)
To: Hans de Goede, linux-kernel, platform-driver-x86, Andy Shevchenko
Cc: Andy Shevchenko, Mika Westerberg
On Thu, 03 Oct 2024 18:48:19 +0300, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
>
>
Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.
The list of commits applied:
[1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers
commit: 066c779b094b63754e0742ad8675d72d6c0a46f6
--
i.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-07 9:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-03 15:48 [PATCH v1 1/1] platform/x86: intel_scu_ipc: Don't use "proxy" headers Andy Shevchenko
2024-10-03 16:03 ` Mika Westerberg
2024-10-03 17:03 ` Andy Shevchenko
2024-10-07 9:42 ` Ilpo Järvinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.