[jpoimboe:static-key-deprecated 1/18] kernel/trace/trace_events_hist.c:825:42: error: 'struct static_key_false' has no member named 'enabled'

[jpoimboe:static-key-deprecated 1/18] kernel/trace/trace_events_hist.c:825:42: error: 'struct static_key_false' has no member named 'enabled'

[kernel test robot]

Hi Josh,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git static-key-deprecated
head:   02560a85ce2d5e66cd2b6f92bc5491f6fd199e02
commit: dcb3457da83c22aae3efcd93357f35c70645c4bb [1/18] tracepoints: Use new static branch API
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241004/202410040333.vJSL1NXx-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410040333.vJSL1NXx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410040333.vJSL1NXx-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/build_bug.h:5,
                    from include/linux/container_of.h:5,
                    from include/linux/list.h:5,
                    from include/linux/module.h:12,
                    from kernel/trace/trace_events_hist.c:8:
   kernel/trace/trace_events_hist.c: In function 'trace_synth':
>> kernel/trace/trace_events_hist.c:825:42: error: 'struct static_key_false' has no member named 'enabled'
     825 |         if (unlikely(atomic_read(&tp->key.enabled) > 0)) {
         |                                          ^
   include/linux/compiler.h:77:45: note: in definition of macro 'unlikely'
      77 | # define unlikely(x)    __builtin_expect(!!(x), 0)
         |                                             ^


vim +825 kernel/trace/trace_events_hist.c

7bbab38d07f318 Masami Hiramatsu        2018-11-05  816  
726721a51838e3 Tom Zanussi             2020-05-28  817  typedef void (*synth_probe_func_t) (void *__data, u64 *var_ref_vals,
726721a51838e3 Tom Zanussi             2020-05-28  818  				    unsigned int *var_ref_idx);
4b147936fa5096 Tom Zanussi             2018-01-15  819  
726721a51838e3 Tom Zanussi             2020-05-28  820  static inline void trace_synth(struct synth_event *event, u64 *var_ref_vals,
726721a51838e3 Tom Zanussi             2020-05-28  821  			       unsigned int *var_ref_idx)
4b147936fa5096 Tom Zanussi             2018-01-15  822  {
726721a51838e3 Tom Zanussi             2020-05-28  823  	struct tracepoint *tp = event->tp;
4b147936fa5096 Tom Zanussi             2018-01-15  824  
726721a51838e3 Tom Zanussi             2020-05-28 @825  	if (unlikely(atomic_read(&tp->key.enabled) > 0)) {
726721a51838e3 Tom Zanussi             2020-05-28  826  		struct tracepoint_func *probe_func_ptr;
726721a51838e3 Tom Zanussi             2020-05-28  827  		synth_probe_func_t probe_func;
726721a51838e3 Tom Zanussi             2020-05-28  828  		void *__data;
17911ff38aa58d Steven Rostedt (VMware  2019-10-11  829) 
726721a51838e3 Tom Zanussi             2020-05-28  830  		if (!(cpu_online(raw_smp_processor_id())))
726721a51838e3 Tom Zanussi             2020-05-28  831  			return;
4b147936fa5096 Tom Zanussi             2018-01-15  832  
726721a51838e3 Tom Zanussi             2020-05-28  833  		probe_func_ptr = rcu_dereference_sched((tp)->funcs);
726721a51838e3 Tom Zanussi             2020-05-28  834  		if (probe_func_ptr) {
726721a51838e3 Tom Zanussi             2020-05-28  835  			do {
726721a51838e3 Tom Zanussi             2020-05-28  836  				probe_func = probe_func_ptr->func;
726721a51838e3 Tom Zanussi             2020-05-28  837  				__data = probe_func_ptr->data;
726721a51838e3 Tom Zanussi             2020-05-28  838  				probe_func(__data, var_ref_vals, var_ref_idx);
726721a51838e3 Tom Zanussi             2020-05-28  839  			} while ((++probe_func_ptr)->func);
726721a51838e3 Tom Zanussi             2020-05-28  840  		}
726721a51838e3 Tom Zanussi             2020-05-28  841  	}
4b147936fa5096 Tom Zanussi             2018-01-15  842  }
4b147936fa5096 Tom Zanussi             2018-01-15  843  

:::::: The code at line 825 was first introduced by commit
:::::: 726721a51838e3983023f906580722fc83f804ee tracing: Move synthetic events to a separate file

:::::: TO: Tom Zanussi <zanussi@kernel.org>
:::::: CC: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki