Re: [PATCH 02/20] ARM: dts: renesas: Use interrupts-extended for Ethernet PHYs

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

On 2024-10-04 14:52:44 +0200, Geert Uytterhoeven wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupts.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  arch/arm/boot/dts/renesas/r8a7743-sk-rzg1m.dts    | 3 +--
>  arch/arm/boot/dts/renesas/r8a7745-sk-rzg1e.dts    | 3 +--
>  arch/arm/boot/dts/renesas/r8a77470-iwg23s-sbc.dts | 3 +--
>  arch/arm/boot/dts/renesas/r8a7790-lager.dts       | 3 +--
>  arch/arm/boot/dts/renesas/r8a7790-stout.dts       | 3 +--
>  arch/arm/boot/dts/renesas/r8a7791-koelsch.dts     | 3 +--
>  arch/arm/boot/dts/renesas/r8a7791-porter.dts      | 3 +--
>  arch/arm/boot/dts/renesas/r8a7793-gose.dts        | 3 +--
>  arch/arm/boot/dts/renesas/r8a7794-alt.dts         | 3 +--
>  arch/arm/boot/dts/renesas/r8a7794-silk.dts        | 3 +--
>  10 files changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/renesas/r8a7743-sk-rzg1m.dts b/arch/arm/boot/dts/renesas/r8a7743-sk-rzg1m.dts
> index ff274bfcb6646ea7..9b16fe7ce713c903 100644
> --- a/arch/arm/boot/dts/renesas/r8a7743-sk-rzg1m.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7743-sk-rzg1m.dts
> @@ -73,8 +73,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc>;
> -		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc 0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7745-sk-rzg1e.dts b/arch/arm/boot/dts/renesas/r8a7745-sk-rzg1e.dts
> index 0a75e8c79acc0e58..571615a506207169 100644
> --- a/arch/arm/boot/dts/renesas/r8a7745-sk-rzg1e.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7745-sk-rzg1e.dts
> @@ -68,8 +68,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc>;
> -		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc 8 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/renesas/r8a77470-iwg23s-sbc.dts
> index 6448022852491661..7c7a9f257567d4f8 100644
> --- a/arch/arm/boot/dts/renesas/r8a77470-iwg23s-sbc.dts
> +++ b/arch/arm/boot/dts/renesas/r8a77470-iwg23s-sbc.dts
> @@ -82,8 +82,7 @@ phy3: ethernet-phy@3 {
>  		compatible = "ethernet-phy-id0022.1622",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <3>;
> -		interrupt-parent = <&gpio5>;
> -		interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&gpio5 16 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  	};
>  };
> diff --git a/arch/arm/boot/dts/renesas/r8a7790-lager.dts b/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> index 826a29064d27f663..97c13b31f476505c 100644
> --- a/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> @@ -692,8 +692,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7790-stout.dts b/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> index 683f7395fab0b696..1593609064104ae4 100644
> --- a/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> @@ -211,8 +211,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 1 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> index 0a8eac57135f2e81..758d8331e7af66c4 100644
> --- a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> @@ -659,8 +659,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7791-porter.dts b/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> index 93c86e9216455577..267b3623655fbc38 100644
> --- a/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> @@ -329,8 +329,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7793-gose.dts b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> index 1ea6c757893bc0bf..f3f62206088348c6 100644
> --- a/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> @@ -622,8 +622,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 0 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio5 22 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7794-alt.dts b/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> index b5ecafbb2e4de582..1e04b8630ef3f3ca 100644
> --- a/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> @@ -381,8 +381,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 8 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  	};
> diff --git a/arch/arm/boot/dts/renesas/r8a7794-silk.dts b/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> index 595e074085eb4cd3..8857bb4a9b91d969 100644
> --- a/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> @@ -415,8 +415,7 @@ phy1: ethernet-phy@1 {
>  		compatible = "ethernet-phy-id0022.1537",
>  			     "ethernet-phy-ieee802.3-c22";
>  		reg = <1>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <8 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 8 IRQ_TYPE_LEVEL_LOW>;
>  		micrel,led-mode = <1>;
>  		reset-gpios = <&gpio1 24 GPIO_ACTIVE_LOW>;
>  	};
> -- 
> 2.34.1
> 
> 

-- 
Kind Regards,
Niklas Söderlund