Re: [PATCH 04/20] ARM: dts: renesas: Use interrupts-extended for PMICs

["Niklas Söderlund" <niklas.soderlund@ragnatech.se>]

On 2024-10-04 14:52:46 +0200, Geert Uytterhoeven wrote:
> Use the more concise interrupts-extended property to fully describe the
> interrupts.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
>  arch/arm/boot/dts/renesas/r8a7790-lager.dts   | 6 ++----
>  arch/arm/boot/dts/renesas/r8a7790-stout.dts   | 9 +++------
>  arch/arm/boot/dts/renesas/r8a7791-koelsch.dts | 6 ++----
>  arch/arm/boot/dts/renesas/r8a7791-porter.dts  | 6 ++----
>  arch/arm/boot/dts/renesas/r8a7792-blanche.dts | 3 +--
>  arch/arm/boot/dts/renesas/r8a7793-gose.dts    | 6 ++----
>  arch/arm/boot/dts/renesas/r8a7794-alt.dts     | 3 +--
>  arch/arm/boot/dts/renesas/r8a7794-silk.dts    | 3 +--
>  8 files changed, 14 insertions(+), 28 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/renesas/r8a7790-lager.dts b/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> index 5ef87f8088c4c81c..47ffa278a0dfd79e 100644
> --- a/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7790-lager.dts
> @@ -443,8 +443,7 @@ i2cpwr: i2c-mux4 {
>  		pmic@58 {
>  			compatible = "dlg,da9063";
>  			reg = <0x58>;
> -			interrupt-parent = <&irqc0>;
> -			interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +			interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  			interrupt-controller;
>  			#interrupt-cells = <2>;
>  
> @@ -460,8 +459,7 @@ watchdog {
>  		vdd_dvfs: regulator@68 {
>  			compatible = "dlg,da9210";
>  			reg = <0x68>;
> -			interrupt-parent = <&irqc0>;
> -			interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +			interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  			regulator-min-microvolt = <1000000>;
>  			regulator-max-microvolt = <1000000>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7790-stout.dts b/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> index 9287724187ef3b69..d7c0a9574ce83144 100644
> --- a/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7790-stout.dts
> @@ -342,8 +342,7 @@ &iic3 {
>  	pmic@58 {
>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> @@ -363,8 +362,7 @@ watchdog {
>  	vdd_dvfs: regulator@68 {
>  		compatible = "dlg,da9210";
>  		reg = <0x68>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  		regulator-min-microvolt = <1000000>;
>  		regulator-max-microvolt = <1000000>;
> @@ -375,8 +373,7 @@ vdd_dvfs: regulator@68 {
>  	vdd: regulator@70 {
>  		compatible = "dlg,da9210";
>  		reg = <0x70>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  		regulator-min-microvolt = <1000000>;
>  		regulator-max-microvolt = <1000000>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> index bce93db4c9df5e18..1a0d2c6ed0e83ce7 100644
> --- a/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-koelsch.dts
> @@ -814,8 +814,7 @@ &i2c6 {
>  	pmic@58 {
>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> @@ -831,8 +830,7 @@ watchdog {
>  	vdd_dvfs: regulator@68 {
>  		compatible = "dlg,da9210";
>  		reg = <0x68>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  		regulator-min-microvolt = <1000000>;
>  		regulator-max-microvolt = <1000000>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7791-porter.dts b/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> index 92b54e043795ba08..08381498350aacde 100644
> --- a/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7791-porter.dts
> @@ -408,8 +408,7 @@ &i2c6 {
>  	pmic@5a {
>  		compatible = "dlg,da9063l";
>  		reg = <0x5a>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> @@ -421,8 +420,7 @@ watchdog {
>  	vdd_dvfs: regulator@68 {
>  		compatible = "dlg,da9210";
>  		reg = <0x68>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  		regulator-min-microvolt = <1000000>;
>  		regulator-max-microvolt = <1000000>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7792-blanche.dts b/arch/arm/boot/dts/renesas/r8a7792-blanche.dts
> index 69009535814406fe..a3986076d8e3e993 100644
> --- a/arch/arm/boot/dts/renesas/r8a7792-blanche.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7792-blanche.dts
> @@ -376,8 +376,7 @@ pmic@58 {
>  		reg = <0x58>;
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pmic_irq_pins>;
> -		interrupt-parent = <&irqc>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc 2 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> diff --git a/arch/arm/boot/dts/renesas/r8a7793-gose.dts b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> index 45ef1d1900245a11..5334af25c10111c8 100644
> --- a/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7793-gose.dts
> @@ -754,8 +754,7 @@ &i2c6 {
>  	pmic@58 {
>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> @@ -771,8 +770,7 @@ watchdog {
>  	vdd_dvfs: regulator@68 {
>  		compatible = "dlg,da9210";
>  		reg = <0x68>;
> -		interrupt-parent = <&irqc0>;
> -		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&irqc0 2 IRQ_TYPE_LEVEL_LOW>;
>  
>  		regulator-min-microvolt = <1000000>;
>  		regulator-max-microvolt = <1000000>;
> diff --git a/arch/arm/boot/dts/renesas/r8a7794-alt.dts b/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> index 1e04b8630ef3f3ca..882644cd7c1875c1 100644
> --- a/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7794-alt.dts
> @@ -449,8 +449,7 @@ &i2c7 {
>  	pmic@58 {
>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
> -		interrupt-parent = <&gpio3>;
> -		interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&gpio3 31 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> diff --git a/arch/arm/boot/dts/renesas/r8a7794-silk.dts b/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> index 5ed5b426f9639775..2a0819311a3c4ef3 100644
> --- a/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> +++ b/arch/arm/boot/dts/renesas/r8a7794-silk.dts
> @@ -434,8 +434,7 @@ &i2c7 {
>  	pmic@58 {
>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
> -		interrupt-parent = <&gpio3>;
> -		interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> +		interrupts-extended = <&gpio3 31 IRQ_TYPE_LEVEL_LOW>;
>  		interrupt-controller;
>  		#interrupt-cells = <2>;
>  
> -- 
> 2.34.1
> 
> 

-- 
Kind Regards,
Niklas Söderlund