From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Thorsten Blum <thorsten.blum@linux.dev>,
linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
Date: Mon, 7 Oct 2024 13:46:37 +0200 [thread overview]
Message-ID: <20241007114638.1337-1-thorsten.blum@linux.dev> (raw)
Use struct_size() to calculate the number of bytes to allocate for a
cloned acl.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/f2fs/acl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 8bffdeccdbc3..1fbc0607363b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl,
struct posix_acl *clone = NULL;
if (acl) {
- int size = sizeof(struct posix_acl) + acl->a_count *
- sizeof(struct posix_acl_entry);
- clone = kmemdup(acl, size, flags);
+ clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count),
+ flags);
if (clone)
refcount_set(&clone->a_refcount, 1);
}
--
2.46.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
Date: Mon, 7 Oct 2024 13:46:37 +0200 [thread overview]
Message-ID: <20241007114638.1337-1-thorsten.blum@linux.dev> (raw)
Use struct_size() to calculate the number of bytes to allocate for a
cloned acl.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/f2fs/acl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 8bffdeccdbc3..1fbc0607363b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl,
struct posix_acl *clone = NULL;
if (acl) {
- int size = sizeof(struct posix_acl) + acl->a_count *
- sizeof(struct posix_acl_entry);
- clone = kmemdup(acl, size, flags);
+ clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count),
+ flags);
if (clone)
refcount_set(&clone->a_refcount, 1);
}
--
2.46.2
next reply other threads:[~2024-10-07 11:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 11:46 Thorsten Blum [this message]
2024-10-07 11:46 ` [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone() Thorsten Blum
2024-10-08 8:51 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2024-10-08 8:51 ` Chao Yu
-- strict thread matches above, loose matches on Subject: below --
2024-10-17 22:05 [f2fs-dev] " Thorsten Blum
2024-10-28 11:20 Thorsten Blum
2024-10-28 17:40 ` patchwork-bot+f2fs--- via Linux-f2fs-devel
2024-10-28 17:40 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007114638.1337-1-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.