From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT SW reset
Date: Mon, 7 Oct 2024 12:59:49 -0500 [thread overview]
Message-ID: <20241007175949.GA1738291-robh@kernel.org> (raw)
In-Reply-To: <20241007063408.2360874-2-chin-ting_kuo@aspeedtech.com>
On Mon, Oct 07, 2024 at 02:34:05PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,restart-sw" property to distinguish normal WDT
> reset from system restart triggered by SW consciously.
>
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
> .../bindings/watchdog/aspeed,ast2400-wdt.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> index be78a9865584..6cc3604c295a 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> @@ -95,6 +95,17 @@ properties:
> array with the first word defined using the AST2600_WDT_RESET1_* macros,
> and the second word defined using the AST2600_WDT_RESET2_* macros.
>
> + aspeed,restart-sw:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: >
> + Normally, ASPEED WDT reset may occur when system hangs or reboot
> + triggered by SW consciously. However, system doesn't know whether the
> + restart is triggered by SW consciously since the reset event flag is
> + the same as normal WDT timeout reset. With this property, SW can
> + restart the system immediately and directly without wait for WDT
> + timeout occurs. The reset event flag is also different from the normal
> + WDT reset. This property is only supported since AST2600 platform.
Why can't this be implicit based on the ast2600 compatible string?
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
Cc: patrick@stwcx.xyz, wim@linux-watchdog.org, linux@roeck-us.net,
krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au,
andrew@codeconstruct.com.au, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Peter.Yin@quantatw.com, Patrick_NC_Lin@wiwynn.com,
Bonnie_Lo@wiwynn.com, DELPHINE_CHIU@wiwynn.com,
BMC-SW@aspeedtech.com
Subject: Re: [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT SW reset
Date: Mon, 7 Oct 2024 12:59:49 -0500 [thread overview]
Message-ID: <20241007175949.GA1738291-robh@kernel.org> (raw)
In-Reply-To: <20241007063408.2360874-2-chin-ting_kuo@aspeedtech.com>
On Mon, Oct 07, 2024 at 02:34:05PM +0800, Chin-Ting Kuo wrote:
> Add "aspeed,restart-sw" property to distinguish normal WDT
> reset from system restart triggered by SW consciously.
>
> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> ---
> .../bindings/watchdog/aspeed,ast2400-wdt.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> index be78a9865584..6cc3604c295a 100644
> --- a/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/aspeed,ast2400-wdt.yaml
> @@ -95,6 +95,17 @@ properties:
> array with the first word defined using the AST2600_WDT_RESET1_* macros,
> and the second word defined using the AST2600_WDT_RESET2_* macros.
>
> + aspeed,restart-sw:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: >
> + Normally, ASPEED WDT reset may occur when system hangs or reboot
> + triggered by SW consciously. However, system doesn't know whether the
> + restart is triggered by SW consciously since the reset event flag is
> + the same as normal WDT timeout reset. With this property, SW can
> + restart the system immediately and directly without wait for WDT
> + timeout occurs. The reset event flag is also different from the normal
> + WDT reset. This property is only supported since AST2600 platform.
Why can't this be implicit based on the ast2600 compatible string?
Rob
next prev parent reply other threads:[~2024-10-07 17:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 6:34 [PATCH 0/4] [PATCH 0/4] Update ASPEED WDT bootstatus Chin-Ting Kuo
2024-10-07 6:34 ` Chin-Ting Kuo
2024-10-07 6:34 ` [PATCH 1/4] dt-bindings: watchdog: aspeed: Add property for WDT SW reset Chin-Ting Kuo
2024-10-07 6:34 ` Chin-Ting Kuo
2024-10-07 6:58 ` Krzysztof Kozlowski
2024-10-07 6:58 ` Krzysztof Kozlowski
2024-10-14 2:07 ` Chin-Ting Kuo
2024-10-14 2:07 ` Chin-Ting Kuo
2024-10-14 6:53 ` Krzysztof Kozlowski
2024-10-14 6:53 ` Krzysztof Kozlowski
2024-10-14 9:58 ` Chin-Ting Kuo
2024-10-14 9:58 ` Chin-Ting Kuo
2024-10-07 17:59 ` Rob Herring [this message]
2024-10-07 17:59 ` Rob Herring
2024-10-07 19:54 ` Guenter Roeck
2024-10-07 19:54 ` Guenter Roeck
2024-10-14 2:08 ` Chin-Ting Kuo
2024-10-14 2:08 ` Chin-Ting Kuo
2024-10-14 2:07 ` Chin-Ting Kuo
2024-10-14 2:07 ` Chin-Ting Kuo
2024-10-07 6:34 ` [PATCH 2/4] ARM: dts: aspeed: Add WDT controller into alias field Chin-Ting Kuo
2024-10-07 6:34 ` Chin-Ting Kuo
2024-10-07 6:34 ` [PATCH 3/4] watchdog: aspeed: Update bootstatus handling Chin-Ting Kuo
2024-10-07 6:34 ` Chin-Ting Kuo
2024-10-07 6:34 ` [PATCH 4/4] watchdog: aspeed: Add support for SW restart Chin-Ting Kuo
2024-10-07 6:34 ` Chin-Ting Kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007175949.GA1738291-robh@kernel.org \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.