From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: mmc: controller: move properties common with slot out to mmc-controller-common
Date: Mon, 7 Oct 2024 15:02:30 -0500 [thread overview]
Message-ID: <20241007200230.GA2301832-robh@kernel.org> (raw)
In-Reply-To: <20241007-topic-amlogic-arm32-upstream-bindings-fixes-convert-meson-mx-sdio-v3-1-ad4eb22c2a8d@linaro.org>
On Mon, Oct 07, 2024 at 04:03:37PM +0200, Neil Armstrong wrote:
> Move the common MMC "slot" properties because they are shared by the
> single-slot or multi-slot controllers, and will help defining a simple
> mmc-slot bindings document with proper slot properties and nodename.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/mmc/mmc-controller-common.yaml | 357 +++++++++++++++++++++
> .../devicetree/bindings/mmc/mmc-controller.yaml | 344 +-------------------
> 2 files changed, 360 insertions(+), 341 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> new file mode 100644
> index 000000000000..e02d3cbcc271
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> @@ -0,0 +1,357 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/mmc-controller-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MMC Controller & Slots Common Properties
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +description: |
> + These properties are common to multiple MMC host controllers and the
> + possible slots or ports for multi-slot controllers.
> +
> +properties:
> + "#address-cells":
> + const: 1
> + description: |
> + The cell is the slot ID if a function subnode is used.
Actually, this comment is wrong. When slot is used, this is still the
cell size for the mmc bus.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: mmc: controller: move properties common with slot out to mmc-controller-common
Date: Mon, 7 Oct 2024 15:02:30 -0500 [thread overview]
Message-ID: <20241007200230.GA2301832-robh@kernel.org> (raw)
In-Reply-To: <20241007-topic-amlogic-arm32-upstream-bindings-fixes-convert-meson-mx-sdio-v3-1-ad4eb22c2a8d@linaro.org>
On Mon, Oct 07, 2024 at 04:03:37PM +0200, Neil Armstrong wrote:
> Move the common MMC "slot" properties because they are shared by the
> single-slot or multi-slot controllers, and will help defining a simple
> mmc-slot bindings document with proper slot properties and nodename.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../bindings/mmc/mmc-controller-common.yaml | 357 +++++++++++++++++++++
> .../devicetree/bindings/mmc/mmc-controller.yaml | 344 +-------------------
> 2 files changed, 360 insertions(+), 341 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> new file mode 100644
> index 000000000000..e02d3cbcc271
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller-common.yaml
> @@ -0,0 +1,357 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/mmc-controller-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MMC Controller & Slots Common Properties
> +
> +maintainers:
> + - Ulf Hansson <ulf.hansson@linaro.org>
> +
> +description: |
> + These properties are common to multiple MMC host controllers and the
> + possible slots or ports for multi-slot controllers.
> +
> +properties:
> + "#address-cells":
> + const: 1
> + description: |
> + The cell is the slot ID if a function subnode is used.
Actually, this comment is wrong. When slot is used, this is still the
cell size for the mmc bus.
next prev parent reply other threads:[~2024-10-07 20:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 14:03 [PATCH v3 0/3] dt-bindings: mmc: document mmc-slot and convert amlogic,meson-mx-sdio.txt to dtschema Neil Armstrong
2024-10-07 14:03 ` Neil Armstrong
2024-10-07 14:03 ` [PATCH v3 1/3] dt-bindings: mmc: controller: move properties common with slot out to mmc-controller-common Neil Armstrong
2024-10-07 14:03 ` Neil Armstrong
2024-10-07 19:58 ` Rob Herring
2024-10-07 19:58 ` Rob Herring
2024-10-08 7:24 ` Neil Armstrong
2024-10-08 7:24 ` Neil Armstrong
2024-10-07 19:58 ` Rob Herring (Arm)
2024-10-07 19:58 ` Rob Herring (Arm)
2024-10-07 20:02 ` Rob Herring [this message]
2024-10-07 20:02 ` Rob Herring
2024-10-08 7:25 ` Neil Armstrong
2024-10-08 7:25 ` Neil Armstrong
2024-10-15 8:34 ` Neil Armstrong
2024-10-15 8:34 ` Neil Armstrong
2024-10-07 14:03 ` [PATCH v3 2/3] dt-bindings: mmc: document mmc-slot Neil Armstrong
2024-10-07 14:03 ` Neil Armstrong
2024-10-07 19:59 ` Rob Herring (Arm)
2024-10-07 19:59 ` Rob Herring (Arm)
2024-10-07 14:03 ` [PATCH v3 3/3] dt-bindings: mmc: convert amlogic,meson-mx-sdio.txt to dtschema Neil Armstrong
2024-10-07 14:03 ` Neil Armstrong
2024-10-07 20:03 ` Rob Herring (Arm)
2024-10-07 20:03 ` Rob Herring (Arm)
2024-10-15 20:02 ` Martin Blumenstingl
2024-10-15 20:02 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007200230.GA2301832-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.