From: Christoph Hellwig <hch@lst.de>
To: "Matias Bjørling" <m@bjorling.me>
Cc: kbusch@kernel.org, hch@lst.de, dlemoal@kernel.org,
cassel@kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matias Bjørling" <matias.bjorling@wdc.com>
Subject: Re: [PATCH 2/2] nvme: add rotational support
Date: Wed, 9 Oct 2024 09:48:05 +0200 [thread overview]
Message-ID: <20241009074805.GC16181@lst.de> (raw)
In-Reply-To: <20241008145503.987195-3-m@bjorling.me>
On Tue, Oct 08, 2024 at 04:55:03PM +0200, Matias Bjørling wrote:
> + if (info->is_rotational)
> + lim.features |= BLK_FEAT_ROTATIONAL | BLK_FEAT_ADD_RANDOM;
Entropy from block devices is pretty useless. The only reason we still
keep it for SCSI is because of retro-computing platforms without a proper
platform hardware RNG. NVMe HDDs reall should not show up in those kinds
of environments. Also without a add_disk_randomness in the nvme I/O
completion handler this won't actually do anything.
next prev parent reply other threads:[~2024-10-09 7:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 14:55 [PATCH 0/2] nvme: add rotational support Matias Bjørling
2024-10-08 14:55 ` [PATCH 1/2] nvme: make independent ns identify default Matias Bjørling
2024-10-09 6:16 ` Hannes Reinecke
2024-10-09 13:59 ` Matias Bjørling
2024-10-09 7:46 ` Christoph Hellwig
2024-10-09 13:19 ` Matias Bjørling
2024-10-10 14:47 ` Daniel Wagner
2024-10-10 15:02 ` Matias Bjørling
2024-10-09 14:56 ` Keith Busch
2024-10-10 7:53 ` Christoph Hellwig
2024-10-08 14:55 ` [PATCH 2/2] nvme: add rotational support Matias Bjørling
2024-10-09 6:17 ` Hannes Reinecke
2024-10-09 7:48 ` Christoph Hellwig [this message]
2024-10-09 13:09 ` Matias Bjørling
2024-10-08 15:13 ` [PATCH 0/2] " Keith Busch
2024-10-08 22:04 ` Keith Busch
2024-10-09 12:56 ` Matias Bjørling
2024-10-08 15:26 ` Martin K. Petersen
2024-10-09 7:43 ` Christoph Hellwig
2024-10-09 13:27 ` Matias Bjørling
2024-10-09 15:39 ` Keith Busch
2024-10-09 18:04 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009074805.GC16181@lst.de \
--to=hch@lst.de \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=matias.bjorling@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.