* [PATCH v3 0/2] Add mmc support for mt7988
@ 2024-10-09 16:55 ` Frank Wunderlich
0 siblings, 0 replies; 8+ messages in thread
From: Frank Wunderlich @ 2024-10-09 16:55 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei
Cc: Frank Wunderlich, linux-mmc, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, daniel, john, eladwf,
ansuelsmth
From: Frank Wunderlich <frank-w@public-files.de>
Add MMC-Support for MT798 SoC
changes in v3:
- use mt7986 platform-data with the mt7988 compatible
changes in v2:
- corrected minItems to require all 4 clocks
Frank Wunderlich (2):
dt-bindings: mmc: mtk-sd: Add mt7988 SoC
mmc: mtk-sd: add support for mt7988
.../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
drivers/mmc/host/mtk-sd.c | 1 +
2 files changed, 25 insertions(+)
--
2.43.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
2024-10-09 16:55 ` Frank Wunderlich
@ 2024-10-09 16:55 ` Frank Wunderlich
-1 siblings, 0 replies; 8+ messages in thread
From: Frank Wunderlich @ 2024-10-09 16:55 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei
Cc: devicetree, linux-mmc, linux-kernel, daniel, linux-mediatek, john,
eladwf, ansuelsmth, linux-arm-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Add binding definitions for mmc on MT7988 SoC.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4
---
.../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index c532ec92d2d9..bec0577b7508 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -21,6 +21,7 @@ properties:
- mediatek,mt7620-mmc
- mediatek,mt7622-mmc
- mediatek,mt7986-mmc
+ - mediatek,mt7988-mmc
- mediatek,mt8135-mmc
- mediatek,mt8173-mmc
- mediatek,mt8183-mmc
@@ -263,6 +264,29 @@ allOf:
- const: bus_clk
- const: sys_cg
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - mediatek,mt7988-mmc
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ items:
+ - description: source clock
+ - description: HCLK which used for host
+ - description: Advanced eXtensible Interface
+ - description: Advanced High-performance Bus clock
+ clock-names:
+ minItems: 4
+ items:
+ - const: source
+ - const: hclk
+ - const: axi_cg
+ - const: ahb_cg
+
- if:
properties:
compatible:
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
@ 2024-10-09 16:55 ` Frank Wunderlich
0 siblings, 0 replies; 8+ messages in thread
From: Frank Wunderlich @ 2024-10-09 16:55 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei
Cc: Frank Wunderlich, linux-mmc, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, daniel, john, eladwf,
ansuelsmth
From: Frank Wunderlich <frank-w@public-files.de>
Add binding definitions for mmc on MT7988 SoC.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
v3:
- fixed minItems on clock-names too
v2:
- fixed minItems to 4
---
.../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index c532ec92d2d9..bec0577b7508 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -21,6 +21,7 @@ properties:
- mediatek,mt7620-mmc
- mediatek,mt7622-mmc
- mediatek,mt7986-mmc
+ - mediatek,mt7988-mmc
- mediatek,mt8135-mmc
- mediatek,mt8173-mmc
- mediatek,mt8183-mmc
@@ -263,6 +264,29 @@ allOf:
- const: bus_clk
- const: sys_cg
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - mediatek,mt7988-mmc
+ then:
+ properties:
+ clocks:
+ minItems: 4
+ items:
+ - description: source clock
+ - description: HCLK which used for host
+ - description: Advanced eXtensible Interface
+ - description: Advanced High-performance Bus clock
+ clock-names:
+ minItems: 4
+ items:
+ - const: source
+ - const: hclk
+ - const: axi_cg
+ - const: ahb_cg
+
- if:
properties:
compatible:
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
2024-10-09 16:55 ` Frank Wunderlich
@ 2024-10-09 19:49 ` Rob Herring (Arm)
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2024-10-09 19:49 UTC (permalink / raw)
To: Frank Wunderlich
Cc: devicetree, Conor Dooley, Wenbin Mei, linux-mmc, daniel,
linux-kernel, Matthias Brugger, linux-mediatek, Chaotian Jing,
john, eladwf, Krzysztof Kozlowski, Ulf Hansson, ansuelsmth,
linux-arm-kernel, AngeloGioacchino Del Regno
On Wed, 09 Oct 2024 18:55:41 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add binding definitions for mmc on MT7988 SoC.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v3:
> - fixed minItems on clock-names too
> v2:
> - fixed minItems to 4
> ---
> .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clocks: 'oneOf' conditional failed, one must be fixed:
[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too long
[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too long
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009165547.5959-2-linux@fw-web.de
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: mmc: mtk-sd: Add mt7988 SoC
@ 2024-10-09 19:49 ` Rob Herring (Arm)
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2024-10-09 19:49 UTC (permalink / raw)
To: Frank Wunderlich
Cc: linux-arm-kernel, eladwf, daniel, ansuelsmth, Conor Dooley,
Frank Wunderlich, AngeloGioacchino Del Regno, linux-kernel,
Ulf Hansson, linux-mediatek, devicetree, Matthias Brugger, john,
Krzysztof Kozlowski, linux-mmc, Chaotian Jing, Wenbin Mei
On Wed, 09 Oct 2024 18:55:41 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add binding definitions for mmc on MT7988 SoC.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> v3:
> - fixed minItems on clock-names too
> v2:
> - fixed minItems to 4
> ---
> .../devicetree/bindings/mmc/mtk-sd.yaml | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clocks: 'oneOf' conditional failed, one must be fixed:
[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too long
[{'description': 'source clock'}, {'description': 'HCLK which used for host'}, {'description': 'Advanced eXtensible Interface'}, {'description': 'Advanced High-performance Bus clock'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml: allOf:5:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too long
[{'const': 'source'}, {'const': 'hclk'}, {'const': 'axi_cg'}, {'const': 'ahb_cg'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241009165547.5959-2-linux@fw-web.de
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] mmc: mtk-sd: add support for mt7988
2024-10-09 16:55 ` Frank Wunderlich
@ 2024-10-09 16:55 ` Frank Wunderlich
-1 siblings, 0 replies; 8+ messages in thread
From: Frank Wunderlich @ 2024-10-09 16:55 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei
Cc: devicetree, linux-mmc, linux-kernel, daniel, linux-mediatek, john,
eladwf, ansuelsmth, linux-arm-kernel
From: Frank Wunderlich <frank-w@public-files.de>
Add support for mmc on MT7988 SoC.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
changes:
v3:
- reuse mt7986 platform data instead of copy
---
drivers/mmc/host/mtk-sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 89018b6c97b9..aaf27fd211c1 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -629,6 +629,7 @@ static const struct of_device_id msdc_of_ids[] = {
{ .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat},
{ .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat},
{ .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat},
+ { .compatible = "mediatek,mt7988-mmc", .data = &mt7986_compat},
{ .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
{ .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
{ .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v3 2/2] mmc: mtk-sd: add support for mt7988
@ 2024-10-09 16:55 ` Frank Wunderlich
0 siblings, 0 replies; 8+ messages in thread
From: Frank Wunderlich @ 2024-10-09 16:55 UTC (permalink / raw)
To: Chaotian Jing, Ulf Hansson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Matthias Brugger, AngeloGioacchino Del Regno,
Wenbin Mei
Cc: Frank Wunderlich, linux-mmc, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek, daniel, john, eladwf,
ansuelsmth
From: Frank Wunderlich <frank-w@public-files.de>
Add support for mmc on MT7988 SoC.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
changes:
v3:
- reuse mt7986 platform data instead of copy
---
drivers/mmc/host/mtk-sd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 89018b6c97b9..aaf27fd211c1 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -629,6 +629,7 @@ static const struct of_device_id msdc_of_ids[] = {
{ .compatible = "mediatek,mt7620-mmc", .data = &mt7620_compat},
{ .compatible = "mediatek,mt7622-mmc", .data = &mt7622_compat},
{ .compatible = "mediatek,mt7986-mmc", .data = &mt7986_compat},
+ { .compatible = "mediatek,mt7988-mmc", .data = &mt7986_compat},
{ .compatible = "mediatek,mt8135-mmc", .data = &mt8135_compat},
{ .compatible = "mediatek,mt8173-mmc", .data = &mt8173_compat},
{ .compatible = "mediatek,mt8183-mmc", .data = &mt8183_compat},
--
2.43.0
^ permalink raw reply related [flat|nested] 8+ messages in thread