From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 1/2] dt-bindings: interrupt-controller: Add support for ASPEED AST27XX INTC
Date: Wed, 9 Oct 2024 16:11:16 -0500 [thread overview]
Message-ID: <20241009211116.GA676770-robh@kernel.org> (raw)
In-Reply-To: <20241009115813.2908803-2-kevin_chen@aspeedtech.com>
On Wed, Oct 09, 2024 at 07:58:12PM +0800, Kevin Chen wrote:
> The ASPEED AST27XX interrupt controller(INTC) contain second level and
> third level interrupt controller.
>
> INTC0:
> The second level INTC, which used to assert GIC(#192~#197) if interrupt
> in INTC1 asserted. There are 6 GIC interrupt number(#192~#197) used in
> one INTC0.
>
> INTC1_x:
> The third level INTC, which used to assert GIC(#192~#197) if interrupt in
> INTC1 asserted. There are 6 GIC interrupt number(#192~#197) used in one INTC0.
>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
> .../aspeed,ast2700-intc.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
> new file mode 100644
> index 000000000000..650a1f6e1177
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aspeed AST2700 Interrupt Controller
> +
> +description:
> + This interrupt controller hardware is second level interrupt controller that
> + is hooked to a parent interrupt controller. It's useful to combine multiple
> + interrupt sources into 1 interrupt to parent interrupt controller.
> +
> +maintainers:
> + - Kevin Chen <kevin_chen@aspeedtech.com>
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2700-intc-ic
> +
> + reg:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 2
Describe the meaning of the cells here.
> +
> + interrupts:
> + maxItems: 10
> + description:
You need '|' to preserve formatting.
> + Depend to which INTC0 or INTC1 used.
> + INTC0 and INTC1 are two kinds of interrupt controller with enable and raw
> + status registers for use.
> + INTC0 is used to assert GIC if interrupt in INTC1 asserted.
> + INTC1 is used to assert INTC0 if interrupt of modules asserted.
> + +-----+ +-------+ +---------+---module0
> + | GIC |---| INTC0 |--+--| INTC1_0 |---module2
> + | | | | | | |---...
> + +-----+ +-------+ | +---------+---module31
> + |
> + | +---------+---module0
> + +---| INTC1_1 |---module2
> + | | |---...
> + | +---------+---module31
> + ...
> + | +---------+---module0
> + +---| INTC1_5 |---module2
> + | |---...
> + +---------+---module31
> +
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - '#interrupt-cells'
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + interrupt-controller at 12101b00 {
> + compatible = "aspeed,ast2700-intc-ic";
> + reg = <0 0x12101b00 0 0x10>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>
Cc: tglx@linutronix.de, krzk+dt@kernel.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v3 1/2] dt-bindings: interrupt-controller: Add support for ASPEED AST27XX INTC
Date: Wed, 9 Oct 2024 16:11:16 -0500 [thread overview]
Message-ID: <20241009211116.GA676770-robh@kernel.org> (raw)
In-Reply-To: <20241009115813.2908803-2-kevin_chen@aspeedtech.com>
On Wed, Oct 09, 2024 at 07:58:12PM +0800, Kevin Chen wrote:
> The ASPEED AST27XX interrupt controller(INTC) contain second level and
> third level interrupt controller.
>
> INTC0:
> The second level INTC, which used to assert GIC(#192~#197) if interrupt
> in INTC1 asserted. There are 6 GIC interrupt number(#192~#197) used in
> one INTC0.
>
> INTC1_x:
> The third level INTC, which used to assert GIC(#192~#197) if interrupt in
> INTC1 asserted. There are 6 GIC interrupt number(#192~#197) used in one INTC0.
>
> Signed-off-by: Kevin Chen <kevin_chen@aspeedtech.com>
> ---
> .../aspeed,ast2700-intc.yaml | 87 +++++++++++++++++++
> 1 file changed, 87 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
>
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
> new file mode 100644
> index 000000000000..650a1f6e1177
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2700-intc.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aspeed AST2700 Interrupt Controller
> +
> +description:
> + This interrupt controller hardware is second level interrupt controller that
> + is hooked to a parent interrupt controller. It's useful to combine multiple
> + interrupt sources into 1 interrupt to parent interrupt controller.
> +
> +maintainers:
> + - Kevin Chen <kevin_chen@aspeedtech.com>
> +
> +properties:
> + compatible:
> + enum:
> + - aspeed,ast2700-intc-ic
> +
> + reg:
> + maxItems: 1
> +
> + interrupt-controller: true
> +
> + '#interrupt-cells':
> + const: 2
Describe the meaning of the cells here.
> +
> + interrupts:
> + maxItems: 10
> + description:
You need '|' to preserve formatting.
> + Depend to which INTC0 or INTC1 used.
> + INTC0 and INTC1 are two kinds of interrupt controller with enable and raw
> + status registers for use.
> + INTC0 is used to assert GIC if interrupt in INTC1 asserted.
> + INTC1 is used to assert INTC0 if interrupt of modules asserted.
> + +-----+ +-------+ +---------+---module0
> + | GIC |---| INTC0 |--+--| INTC1_0 |---module2
> + | | | | | | |---...
> + +-----+ +-------+ | +---------+---module31
> + |
> + | +---------+---module0
> + +---| INTC1_1 |---module2
> + | | |---...
> + | +---------+---module31
> + ...
> + | +---------+---module0
> + +---| INTC1_5 |---module2
> + | |---...
> + +---------+---module31
> +
> +
> +required:
> + - compatible
> + - reg
> + - interrupt-controller
> + - '#interrupt-cells'
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + bus {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + interrupt-controller@12101b00 {
> + compatible = "aspeed,ast2700-intc-ic";
> + reg = <0 0x12101b00 0 0x10>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-10-09 21:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 11:58 [PATCH v3 0/2] Add support for AST2700 INTC driver Kevin Chen
2024-10-09 11:58 ` Kevin Chen
2024-10-09 11:58 ` [PATCH v3 1/2] dt-bindings: interrupt-controller: Add support for ASPEED AST27XX INTC Kevin Chen
2024-10-09 11:58 ` Kevin Chen
2024-10-09 12:56 ` Markus Elfring
2024-10-09 12:56 ` Markus Elfring
2024-10-09 21:11 ` Rob Herring [this message]
2024-10-09 21:11 ` Rob Herring
2024-10-11 10:02 ` Kevin Chen
2024-10-11 10:02 ` Kevin Chen
2024-10-09 11:58 ` [PATCH v3 2/2] irqchip/aspeed-intc: Add support for " Kevin Chen
2024-10-09 11:58 ` Kevin Chen
2024-10-09 12:32 ` Markus Elfring
2024-10-09 12:32 ` Markus Elfring
2024-10-11 10:06 ` Kevin Chen
2024-10-11 10:06 ` Kevin Chen
2024-10-11 15:34 ` Markus Elfring
2024-10-11 15:34 ` Markus Elfring
2024-10-14 2:00 ` Kevin Chen
2024-10-14 2:00 ` Kevin Chen
2024-10-14 13:10 ` Markus Elfring
2024-10-14 13:10 ` Markus Elfring
2024-10-15 10:19 ` Kevin Chen
2024-10-15 10:19 ` Kevin Chen
2024-10-15 15:07 ` Markus Elfring
2024-10-15 15:07 ` Markus Elfring
2024-10-15 21:42 ` Thomas Gleixner
2024-10-15 21:42 ` Thomas Gleixner
2024-10-16 0:31 ` Kevin Chen
2024-10-16 0:31 ` Kevin Chen
2024-10-16 9:54 ` [v3 " Markus Elfring
2024-10-16 9:54 ` Markus Elfring
2024-10-11 13:06 ` [PATCH v3 " Dan Carpenter
2024-10-11 13:06 ` Dan Carpenter
2024-10-14 0:17 ` Kevin Chen
2024-10-14 0:17 ` Kevin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009211116.GA676770-robh@kernel.org \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.