Re: [PATCH 3/3] net/tap: increase the maximum allowable queues

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 11 Oct 2024 10:29:25 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> The default of 16 is too low for larger systems, and the limit
> is set at compile time.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/tap/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build
> index 5e5a3ad3c6..fa4e6cbec9 100644
> --- a/drivers/net/tap/meson.build
> +++ b/drivers/net/tap/meson.build
> @@ -14,7 +14,7 @@ sources = files(
>  
>  deps = ['bus_vdev', 'gso', 'hash']
>  
> -max_queues = '-DTAP_MAX_QUEUES=16'
> +max_queues = '-DTAP_MAX_QUEUES=64'
>  cflags += max_queues
>  
>  require_iova_in_mbuf = false

Why does this build fail on Loongix? It works on x86 and Arm.
Is it something about being merged to wrong main branch?


Loongnix-Server 8.3
    Kernel: 4.19.190+
    Compiler: gcc 8.3


Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o
cc -Idrivers/libtmp_rte_net_tap.a.p -Idrivers -I../drivers -Idrivers/net/tap -I../drivers/net/tap -Idrivers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/gso -I../lib/gso -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definit
 ion -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DTAP_MAX_QUEUES=64 -DHAVE_TCA_FLOWER -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.tap -MD -MQ drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -MF drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o.d -o drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -c ../drivers/net/tap/rte_eth_tap.c
In file included from ../drivers/net/tap/rte_eth_tap.c:23:
./drivers/net/tap/rte_eth_tap.c:75:1: error: static assertion failed: "TAP max queues exceeds MP fd limit"
static_assert(RTE_PMD_TAP_MAX_QUEUES <= RTE_MP_MAX_FD_NUM, "TAP max queues exceeds MP fd limit");