From: Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@amd.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 0/3] net/tap: queue limit patches
Date: Sat, 12 Oct 2024 17:53:03 -0700 [thread overview]
Message-ID: <20241012175303.6c200a8f@hermes.local> (raw)
In-Reply-To: <d63d59a4-516d-40ed-822e-611a4fc7104f@amd.com>
On Sun, 13 Oct 2024 00:53:54 +0100
Ferruh Yigit <ferruh.yigit@amd.com> wrote:
> On 10/12/2024 3:17 AM, Stephen Hemminger wrote:
> > Some patches related to recent queue limit changes.
> >
> > v2 - up the limit to maximum Linux can support
> > dont use static_assert here
> > get rid of unreachable checks in configure
> >
> > Stephen Hemminger (3):
> > net/tap: handle increase in mp_max_fds
> > net/tap: increase the maximum allowable queues
> > net/tap: remove unnecessary checks in configure
> >
>
> Hi Stephen,
>
> Previous version already merged, but I am checking the difference in v2.
>
> Patch 1/3 is identical.
> Patch 2/3, I prefer the v1 version, that increases the queue limit to
> 64, instead of 253.
Ok, we can bump it later if anyone wants to run on 128 core cpu
>
> v1 patch 3/3 static assert seems gone, it seems because of the loongarch
> build, but can we please root cause why it failed, and can the failure
> be a test environment issue?
Right, not sure what was wrong there, and not easy to setup a loongarch
build (even with qemu) to repro.
> v2 patch 3/3 looks good, it can be merged separately.
Ok, will add it to later follow up set. The tap device driver needs
lots more cleanups.
next prev parent reply other threads:[~2024-10-13 0:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 17:29 [PATCH 0/3] net/tap: queue limit patches Stephen Hemminger
2024-10-11 17:29 ` [PATCH 1/3] net/tap: handle increase in mp_max_fds Stephen Hemminger
2024-10-11 17:29 ` [PATCH 2/3] net/tap: add static assert to make sure max queues less than fd limit Stephen Hemminger
2024-10-11 17:29 ` [PATCH 3/3] net/tap: increase the maximum allowable queues Stephen Hemminger
2024-10-11 19:02 ` Stephen Hemminger
2024-10-12 1:01 ` [PATCH 0/3] net/tap: queue limit patches Ferruh Yigit
2024-10-12 2:20 ` Stephen Hemminger
2024-10-12 2:17 ` [PATCH v2 " Stephen Hemminger
2024-10-12 2:17 ` [PATCH v2 1/3] net/tap: handle increase in mp_max_fds Stephen Hemminger
2024-10-12 2:17 ` [PATCH v2 2/3] net/tap: increase the maximum allowable queues Stephen Hemminger
2024-10-12 2:17 ` [PATCH v2 3/3] net/tap: remove unnecessary checks in configure Stephen Hemminger
2024-10-13 3:12 ` Ferruh Yigit
2024-10-12 23:53 ` [PATCH v2 0/3] net/tap: queue limit patches Ferruh Yigit
2024-10-13 0:53 ` Stephen Hemminger [this message]
2024-10-13 1:32 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012175303.6c200a8f@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.