From: Guan-Yu Lin <guanyulin@google.com>
To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
yajun.deng@linux.dev, sumit.garg@linaro.org, kekrby@gmail.com,
oneukum@suse.com, dianders@chromium.org, perex@perex.cz,
tiwai@suse.com, niko.mauno@vaisala.com, andreyknvl@gmail.com,
christophe.jaillet@wanadoo.fr, tj@kernel.org,
stanley_chang@realtek.com, quic_jjohnson@quicinc.com,
ricardo@marliere.net
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, badhri@google.com,
albertccwang@google.com, quic_wcheng@quicinc.com,
pumahsu@google.com, Guan-Yu Lin <guanyulin@google.com>
Subject: [PATCH v5 2/5] usb: xhci-plat: separate dev_pm_ops for each pm_event
Date: Mon, 14 Oct 2024 08:50:26 +0000 [thread overview]
Message-ID: <20241014085816.1401364-3-guanyulin@google.com> (raw)
In-Reply-To: <20241014085816.1401364-1-guanyulin@google.com>
Separate dev_pm_ops for different power events such as suspend, thaw,
and hibernation. This is crucial when xhci-plat driver needs to adapt
its behavior based on different power state changes.
Signed-off-by: Guan-Yu Lin <guanyulin@google.com>
---
drivers/usb/host/xhci-plat.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index 8dc23812b204..6e49ef1908eb 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -450,7 +450,7 @@ void xhci_plat_remove(struct platform_device *dev)
}
EXPORT_SYMBOL_GPL(xhci_plat_remove);
-static int xhci_plat_suspend(struct device *dev)
+static int xhci_plat_suspend_common(struct device *dev, struct pm_message pmsg)
{
struct usb_hcd *hcd = dev_get_drvdata(dev);
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
@@ -478,6 +478,21 @@ static int xhci_plat_suspend(struct device *dev)
return 0;
}
+static int xhci_plat_suspend(struct device *dev)
+{
+ return xhci_plat_suspend_common(dev, PMSG_SUSPEND);
+}
+
+static int xhci_plat_freeze(struct device *dev)
+{
+ return xhci_plat_suspend_common(dev, PMSG_FREEZE);
+}
+
+static int xhci_plat_poweroff(struct device *dev)
+{
+ return xhci_plat_suspend_common(dev, PMSG_HIBERNATE);
+}
+
static int xhci_plat_resume_common(struct device *dev, struct pm_message pmsg)
{
struct usb_hcd *hcd = dev_get_drvdata(dev);
@@ -524,6 +539,11 @@ static int xhci_plat_resume(struct device *dev)
return xhci_plat_resume_common(dev, PMSG_RESUME);
}
+static int xhci_plat_thaw(struct device *dev)
+{
+ return xhci_plat_resume_common(dev, PMSG_THAW);
+}
+
static int xhci_plat_restore(struct device *dev)
{
return xhci_plat_resume_common(dev, PMSG_RESTORE);
@@ -553,9 +573,9 @@ static int __maybe_unused xhci_plat_runtime_resume(struct device *dev)
const struct dev_pm_ops xhci_plat_pm_ops = {
.suspend = pm_sleep_ptr(xhci_plat_suspend),
.resume = pm_sleep_ptr(xhci_plat_resume),
- .freeze = pm_sleep_ptr(xhci_plat_suspend),
- .thaw = pm_sleep_ptr(xhci_plat_resume),
- .poweroff = pm_sleep_ptr(xhci_plat_suspend),
+ .freeze = pm_sleep_ptr(xhci_plat_freeze),
+ .thaw = pm_sleep_ptr(xhci_plat_thaw),
+ .poweroff = pm_sleep_ptr(xhci_plat_poweroff),
.restore = pm_sleep_ptr(xhci_plat_restore),
SET_RUNTIME_PM_OPS(xhci_plat_runtime_suspend,
--
2.47.0.rc1.288.g06298d1525-goog
next prev parent reply other threads:[~2024-10-14 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 8:50 [PATCH v5 0/5] Support system sleep with offloaded usb transfers Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 1/5] usb: dwc3: separate dev_pm_ops for each pm_event Guan-Yu Lin
2024-10-14 8:50 ` Guan-Yu Lin [this message]
2024-10-14 8:50 ` [PATCH v5 3/5] usb: add apis for sideband usage tracking Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 4/5] xhci: sideband: add api to trace sideband usage Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 5/5] usb: host: enable sideband transfer during system sleep Guan-Yu Lin
2024-10-14 9:21 ` Greg KH
2024-10-14 16:06 ` Guan-Yu Lin
2024-10-14 13:08 ` Mathias Nyman
2024-10-14 16:19 ` Guan-Yu Lin
2024-10-14 15:56 ` Alan Stern
2024-10-14 15:59 ` Alan Stern
2024-10-15 3:56 ` Guan-Yu Lin
2024-10-15 14:43 ` Alan Stern
2024-10-16 7:40 ` Guan-Yu Lin
2024-10-16 14:45 ` Alan Stern
2024-10-18 11:59 ` Guan-Yu Lin
2024-10-18 14:41 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014085816.1401364-3-guanyulin@google.com \
--to=guanyulin@google.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=andreyknvl@gmail.com \
--cc=badhri@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=niko.mauno@vaisala.com \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=pumahsu@google.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=ricardo@marliere.net \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=sumit.garg@linaro.org \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.