From: Guan-Yu Lin <guanyulin@google.com>
To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, stern@rowland.harvard.edu,
yajun.deng@linux.dev, sumit.garg@linaro.org, kekrby@gmail.com,
oneukum@suse.com, dianders@chromium.org, perex@perex.cz,
tiwai@suse.com, niko.mauno@vaisala.com, andreyknvl@gmail.com,
christophe.jaillet@wanadoo.fr, tj@kernel.org,
stanley_chang@realtek.com, quic_jjohnson@quicinc.com,
ricardo@marliere.net
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, badhri@google.com,
albertccwang@google.com, quic_wcheng@quicinc.com,
pumahsu@google.com, Guan-Yu Lin <guanyulin@google.com>
Subject: [PATCH v5 4/5] xhci: sideband: add api to trace sideband usage
Date: Mon, 14 Oct 2024 08:50:28 +0000 [thread overview]
Message-ID: <20241014085816.1401364-5-guanyulin@google.com> (raw)
In-Reply-To: <20241014085816.1401364-1-guanyulin@google.com>
The existing sideband driver only registers sidebands without tracking
their active usage. To address this, new apis are introduced to:
- mark sideband usage: record the sideband usage information in the USB
host controller driver and USB device driver.
- query sideband status: provide a means for other drivers to fetch
sideband activity information on a USB host controller.
Signed-off-by: Guan-Yu Lin <guanyulin@google.com>
---
drivers/usb/host/xhci-sideband.c | 74 +++++++++++++++++++++++++++++++
include/linux/usb/hcd.h | 4 ++
include/linux/usb/xhci-sideband.h | 5 +++
3 files changed, 83 insertions(+)
diff --git a/drivers/usb/host/xhci-sideband.c b/drivers/usb/host/xhci-sideband.c
index d04cf0af57ae..87dd66056324 100644
--- a/drivers/usb/host/xhci-sideband.c
+++ b/drivers/usb/host/xhci-sideband.c
@@ -334,6 +334,80 @@ xhci_sideband_interrupter_id(struct xhci_sideband *sb)
}
EXPORT_SYMBOL_GPL(xhci_sideband_interrupter_id);
+/**
+ * xhci_sideband_get - inform related drivers there's a new active sideband
+ * @sb: sideband instance for this usb device
+ *
+ * An active sideband indicates that another entity is currently using the host
+ * controller. Inform the host controller and related usb devices by increasing
+ * their sb_usage_count. This allows the corresponding drivers to dynamically
+ * adjust power management actions based on current sideband activity.
+ *
+ * Returns 0 on success, negative error otherwise
+ */
+int xhci_sideband_get(struct xhci_sideband *sb)
+{
+ struct usb_hcd *hcd;
+ struct usb_device *udev;
+
+ if (!sb || !sb->xhci)
+ return -ENODEV;
+
+ hcd = xhci_to_hcd(sb->xhci);
+ refcount_inc(&hcd->sb_usage_count);
+
+ udev = sb->vdev->udev;
+ usb_sideband_get(udev);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_get);
+
+/**
+ * xhci_sideband_put - inform related drivers there's a sideband deactivated
+ * @sb: sideband instance for this usb device
+ *
+ * The inverse operation of xhci_sideband_get, which informs the host
+ * controller and related usb devices by decreasing their sb_usage_count. This
+ * allows the corresponding drivers to dynamically adjust power management
+ * actions based on current sideband activity.
+ *
+ * Returns 0 on success, negative error otherwise
+ */
+int xhci_sideband_put(struct xhci_sideband *sb)
+{
+ struct usb_hcd *hcd;
+ struct usb_device *udev;
+
+ if (!sb || !sb->xhci)
+ return -ENODEV;
+
+ hcd = xhci_to_hcd(sb->xhci);
+ refcount_dec(&hcd->sb_usage_count);
+
+ udev = sb->vdev->udev;
+ usb_sideband_put(udev);
+
+ return 0;
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_put);
+
+/**
+ * xhci_sideband_check - check sideband activities on the host controller
+ * @hcd: the host controller driver associated with the target host controller
+ *
+ * Allow other drivers, such as usb controller driver, to check if there are
+ * any sideband activity on the host controller right now. This information
+ * could be used for power management or other forms or resource management.
+ *
+ * Returns true on any active sideband existence, false otherwise
+ */
+bool xhci_sideband_check(struct usb_hcd *hcd)
+{
+ return !!refcount_read(&hcd->sb_usage_count);
+}
+EXPORT_SYMBOL_GPL(xhci_sideband_check);
+
/**
* xhci_sideband_register - register a sideband for a usb device
* @udev: usb device to be accessed via sideband
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index ac95e7c89df5..d4f5e57b0c00 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -84,6 +84,10 @@ struct usb_hcd {
struct urb *status_urb; /* the current status urb */
#ifdef CONFIG_PM
struct work_struct wakeup_work; /* for remote wakeup */
+#ifdef CONFIG_USB_XHCI_SIDEBAND
+ /* Number of active sideband accessing the host controller. */
+ refcount_t sb_usage_count;
+#endif
#endif
struct work_struct died_work; /* for when the device dies */
diff --git a/include/linux/usb/xhci-sideband.h b/include/linux/usb/xhci-sideband.h
index f0223c5535e0..4850fc826e00 100644
--- a/include/linux/usb/xhci-sideband.h
+++ b/include/linux/usb/xhci-sideband.h
@@ -12,6 +12,7 @@
#include <linux/scatterlist.h>
#include <linux/usb.h>
+#include <linux/usb/hcd.h>
#define EP_CTX_PER_DEV 31 /* FIXME defined twice, from xhci.h */
@@ -57,6 +58,10 @@ xhci_sideband_get_endpoint_buffer(struct xhci_sideband *sb,
struct sg_table *
xhci_sideband_get_event_buffer(struct xhci_sideband *sb);
+int xhci_sideband_get(struct xhci_sideband *sb);
+int xhci_sideband_put(struct xhci_sideband *sb);
+bool xhci_sideband_check(struct usb_hcd *hcd);
+
int
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
bool ip_autoclear, u32 imod_interval, int intr_num);
--
2.47.0.rc1.288.g06298d1525-goog
next prev parent reply other threads:[~2024-10-14 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 8:50 [PATCH v5 0/5] Support system sleep with offloaded usb transfers Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 1/5] usb: dwc3: separate dev_pm_ops for each pm_event Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 2/5] usb: xhci-plat: " Guan-Yu Lin
2024-10-14 8:50 ` [PATCH v5 3/5] usb: add apis for sideband usage tracking Guan-Yu Lin
2024-10-14 8:50 ` Guan-Yu Lin [this message]
2024-10-14 8:50 ` [PATCH v5 5/5] usb: host: enable sideband transfer during system sleep Guan-Yu Lin
2024-10-14 9:21 ` Greg KH
2024-10-14 16:06 ` Guan-Yu Lin
2024-10-14 13:08 ` Mathias Nyman
2024-10-14 16:19 ` Guan-Yu Lin
2024-10-14 15:56 ` Alan Stern
2024-10-14 15:59 ` Alan Stern
2024-10-15 3:56 ` Guan-Yu Lin
2024-10-15 14:43 ` Alan Stern
2024-10-16 7:40 ` Guan-Yu Lin
2024-10-16 14:45 ` Alan Stern
2024-10-18 11:59 ` Guan-Yu Lin
2024-10-18 14:41 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014085816.1401364-5-guanyulin@google.com \
--to=guanyulin@google.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=albertccwang@google.com \
--cc=andreyknvl@gmail.com \
--cc=badhri@google.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kekrby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=niko.mauno@vaisala.com \
--cc=oneukum@suse.com \
--cc=perex@perex.cz \
--cc=pumahsu@google.com \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=ricardo@marliere.net \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=sumit.garg@linaro.org \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.