All of lore.kernel.org
 help / color / mirror / Atom feed
* [norov:cpumask_next_wrap4 13/13] kernel/padata.c:277:27: error: implicit declaration of function 'cpumask_next_wrap_old'; did you mean 'cpumask_next_wrap'?
@ 2024-10-14 14:58 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-10-14 14:58 UTC (permalink / raw)
  To: Yury Norov; +Cc: oe-kbuild-all

tree:   https://github.com/norov/linux cpumask_next_wrap4
head:   88192093b9133e4e21485afed62a2779c0025290
commit: 88192093b9133e4e21485afed62a2779c0025290 [13/13] drop cpumask_next_wrap_old
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241014/202410142245.DWSRLFUh-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241014/202410142245.DWSRLFUh-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410142245.DWSRLFUh-lkp@intel.com/

All errors (new ones prefixed by >>):

   kernel/padata.c: In function 'padata_find_next':
>> kernel/padata.c:277:27: error: implicit declaration of function 'cpumask_next_wrap_old'; did you mean 'cpumask_next_wrap'? [-Werror=implicit-function-declaration]
     277 |                 pd->cpu = cpumask_next_wrap_old(cpu, pd->cpumask.pcpu, -1, false);
         |                           ^~~~~~~~~~~~~~~~~~~~~
         |                           cpumask_next_wrap
   cc1: some warnings being treated as errors


vim +277 kernel/padata.c

16295bec6398a3 Steffen Klassert   2010-01-06  237  
0198ffd135f51d Steffen Klassert   2010-05-19  238  /*
bfde23ce200e6d Daniel Jordan      2019-09-05  239   * padata_find_next - Find the next object that needs serialization.
0198ffd135f51d Steffen Klassert   2010-05-19  240   *
bfcdcef8c8e346 Daniel Jordan      2019-12-03  241   * Return:
bfcdcef8c8e346 Daniel Jordan      2019-12-03  242   * * A pointer to the control struct of the next object that needs
0198ffd135f51d Steffen Klassert   2010-05-19  243   *   serialization, if present in one of the percpu reorder queues.
bfcdcef8c8e346 Daniel Jordan      2019-12-03  244   * * NULL, if the next object that needs serialization will
0198ffd135f51d Steffen Klassert   2010-05-19  245   *   be parallel processed by another cpu and is not yet present in
0198ffd135f51d Steffen Klassert   2010-05-19  246   *   the cpu's reorder queue.
0198ffd135f51d Steffen Klassert   2010-05-19  247   */
bfde23ce200e6d Daniel Jordan      2019-09-05  248  static struct padata_priv *padata_find_next(struct parallel_data *pd,
bfde23ce200e6d Daniel Jordan      2019-09-05  249  					    bool remove_object)
16295bec6398a3 Steffen Klassert   2010-01-06  250  {
16295bec6398a3 Steffen Klassert   2010-01-06  251  	struct padata_priv *padata;
16295bec6398a3 Steffen Klassert   2010-01-06  252  	struct padata_list *reorder;
6fc4dbcf027627 Herbert Xu         2019-07-18  253  	int cpu = pd->cpu;
16295bec6398a3 Steffen Klassert   2010-01-06  254  
f601c725a6ac07 Daniel Jordan      2020-07-14  255  	reorder = per_cpu_ptr(pd->reorder_list, cpu);
16295bec6398a3 Steffen Klassert   2010-01-06  256  
de5540d088fe97 Jason A. Donenfeld 2017-03-23  257  	spin_lock(&reorder->lock);
bfde23ce200e6d Daniel Jordan      2019-09-05  258  	if (list_empty(&reorder->list)) {
bfde23ce200e6d Daniel Jordan      2019-09-05  259  		spin_unlock(&reorder->lock);
bfde23ce200e6d Daniel Jordan      2019-09-05  260  		return NULL;
bfde23ce200e6d Daniel Jordan      2019-09-05  261  	}
16295bec6398a3 Steffen Klassert   2010-01-06  262  
bfde23ce200e6d Daniel Jordan      2019-09-05  263  	padata = list_entry(reorder->list.next, struct padata_priv, list);
16295bec6398a3 Steffen Klassert   2010-01-06  264  
bfde23ce200e6d Daniel Jordan      2019-09-05  265  	/*
bfde23ce200e6d Daniel Jordan      2019-09-05  266  	 * Checks the rare case where two or more parallel jobs have hashed to
bfde23ce200e6d Daniel Jordan      2019-09-05  267  	 * the same CPU and one of the later ones finishes first.
bfde23ce200e6d Daniel Jordan      2019-09-05  268  	 */
bfde23ce200e6d Daniel Jordan      2019-09-05  269  	if (padata->seq_nr != pd->processed) {
de5540d088fe97 Jason A. Donenfeld 2017-03-23  270  		spin_unlock(&reorder->lock);
bfde23ce200e6d Daniel Jordan      2019-09-05  271  		return NULL;
16295bec6398a3 Steffen Klassert   2010-01-06  272  	}
16295bec6398a3 Steffen Klassert   2010-01-06  273  
bfde23ce200e6d Daniel Jordan      2019-09-05  274  	if (remove_object) {
bfde23ce200e6d Daniel Jordan      2019-09-05  275  		list_del_init(&padata->list);
bfde23ce200e6d Daniel Jordan      2019-09-05  276  		++pd->processed;
02637a902619a6 Yury Norov         2024-10-07 @277  		pd->cpu = cpumask_next_wrap_old(cpu, pd->cpumask.pcpu, -1, false);
16295bec6398a3 Steffen Klassert   2010-01-06  278  	}
16295bec6398a3 Steffen Klassert   2010-01-06  279  
bfde23ce200e6d Daniel Jordan      2019-09-05  280  	spin_unlock(&reorder->lock);
16295bec6398a3 Steffen Klassert   2010-01-06  281  	return padata;
16295bec6398a3 Steffen Klassert   2010-01-06  282  }
16295bec6398a3 Steffen Klassert   2010-01-06  283  

:::::: The code at line 277 was first introduced by commit
:::::: 02637a902619a6c92c5dc0d39ba1fd9e9f0748e0 cpumask: deprecate cpumask_next_wrap()

:::::: TO: Yury Norov <yury.norov@gmail.com>
:::::: CC: Yury Norov <yury.norov@gmail.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-14 14:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-14 14:58 [norov:cpumask_next_wrap4 13/13] kernel/padata.c:277:27: error: implicit declaration of function 'cpumask_next_wrap_old'; did you mean 'cpumask_next_wrap'? kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.