* [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper
@ 2024-10-15 7:32 Arnd Bergmann
2024-10-15 7:45 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2024-10-15 7:32 UTC (permalink / raw)
To: Stanislav Yakovlev, Kalle Valo, Johannes Berg
Cc: Arnd Bergmann, linux-wireless, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The lib80211 code uses arc4 crypto helpers that can be
disabled:
ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
Select the library from Kconfig to ensure this can be called.
Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/intel/ipw2x00/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/intel/ipw2x00/Kconfig b/drivers/net/wireless/intel/ipw2x00/Kconfig
index 5e98be664d38..98a17c941100 100644
--- a/drivers/net/wireless/intel/ipw2x00/Kconfig
+++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
@@ -6,6 +6,7 @@
config IPW2100
tristate "Intel PRO/Wireless 2100 Network Connection"
depends on PCI && CFG80211
+ select CRYPTO_LIB_ARC4
select WIRELESS_EXT
select WEXT_PRIV
select FW_LOADER
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper
2024-10-15 7:32 [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper Arnd Bergmann
@ 2024-10-15 7:45 ` Johannes Berg
2024-10-15 8:26 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2024-10-15 7:45 UTC (permalink / raw)
To: Arnd Bergmann, Stanislav Yakovlev, Kalle Valo
Cc: Arnd Bergmann, linux-wireless, linux-kernel
On Tue, 2024-10-15 at 07:32 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The lib80211 code uses arc4 crypto helpers that can be
> disabled:
>
> ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
>
> Select the library from Kconfig to ensure this can be called.
>
> Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")
Right, sorry. I sent a similar one before:
https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/
> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
> @@ -6,6 +6,7 @@
> config IPW2100
> tristate "Intel PRO/Wireless 2100 Network Connection"
> depends on PCI && CFG80211
> + select CRYPTO_LIB_ARC4
>
I think this got to the wrong place?
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper
2024-10-15 7:45 ` Johannes Berg
@ 2024-10-15 8:26 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2024-10-15 8:26 UTC (permalink / raw)
To: Johannes Berg, Arnd Bergmann, Stanislav Yakovlev, Kalle Valo
Cc: linux-wireless, linux-kernel
On Tue, Oct 15, 2024, at 07:45, Johannes Berg wrote:
>> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
>> @@ -6,6 +6,7 @@
>> config IPW2100
>> tristate "Intel PRO/Wireless 2100 Network Connection"
>> depends on PCI && CFG80211
>> + select CRYPTO_LIB_ARC4
>>
> I think this got to the wrong place?
Right, your versions is the correct one.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-15 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 7:32 [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper Arnd Bergmann
2024-10-15 7:45 ` Johannes Berg
2024-10-15 8:26 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.