From: Nir Lichtman <nir@lichtman.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: jason.wessel@windriver.com, daniel.thompson@linaro.org,
dianders@chromium.org, corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation: English fixes in kgdb/kdb article
Date: Fri, 18 Oct 2024 17:49:53 +0000 [thread overview]
Message-ID: <20241018174953.GA796860@lichtman.org> (raw)
In-Reply-To: <ZxKaZR_M-mOjSmBp@casper.infradead.org>
On Fri, Oct 18, 2024 at 06:27:01PM +0100, Matthew Wilcox wrote:
> On Fri, Oct 18, 2024 at 04:31:36PM +0000, Nir Lichtman wrote:
> > -Next you should choose one of more I/O drivers to interconnect debugging
> > +Next you should choose one of the I/O drivers to interconnect the debugging
>
> Wrong fix ;-) "one or more".
Will fix in v2 :)
>
> > @@ -201,7 +201,7 @@ Using loadable module or built-in
> > Configure kgdboc at runtime with sysfs
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > -At run time you can enable or disable kgdboc by echoing a parameters
> > +At run time you can enable or disable kgdboc by echoing the parameters
> > into the sysfs. Here are two examples:
>
> Maybe "by writing parameters into sysfs"?
Yah, sounds better will fix as well in v2.
>
> > @@ -631,8 +631,6 @@ automatically changes into kgdb mode.
> >
> > kgdb
> >
> > - Now disconnect your terminal program and connect gdb in its place
> > -
>
> Is there a reason you deleted this? It seems important.
>
Yes, this sentence is duplicated twice (with slightly different wording), here and a line below.
next prev parent reply other threads:[~2024-10-18 17:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 16:31 [PATCH] Documentation: English fixes in kgdb/kdb article Nir Lichtman
2024-10-18 17:27 ` Matthew Wilcox
2024-10-18 17:49 ` Nir Lichtman [this message]
2024-10-18 17:56 ` Matthew Wilcox
2024-10-18 17:55 ` [PATCH v2] " Nir Lichtman
2024-10-18 19:46 ` Doug Anderson
2024-10-18 22:21 ` Nir Lichtman
2024-10-18 22:35 ` [PATCH v3] " Nir Lichtman
2024-10-18 22:49 ` Doug Anderson
2024-10-18 23:10 ` Jonathan Corbet
2024-10-19 5:50 ` Nir Lichtman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241018174953.GA796860@lichtman.org \
--to=nir@lichtman.org \
--cc=corbet@lwn.net \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.